revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-30 09:20:58 +01:00
Code Issues Releases Wiki Activity

Fix Maniphest status change previews

Browse source 
Summary: See IRC. This will be obsoleted by ApplicationTransactions eventually, but fix issues with stauts change previews for now. Specifically, if you select "Reopen Task", it incorrectly previews as "x created this task" because the old state is not set correctly.

Test Plan: Selected "Reopen Task", saw a preview with the correct language.

Reviewers: chad, btrahan

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D8094
This commit is contained in:
epriestley 2014-01-29 10:41:51 -08:00
parent ffed36fd99
commit d504a4d7df
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/maniphest/controller/ManiphestTransactionPreviewController.php
View file

@ -95,6 +95,11 @@ final class ManiphestTransactionPreviewController extends ManiphestController {
$transaction->setOldValue($task->getProjectPHIDs()); $transaction->setOldValue($task->getProjectPHIDs());
$transaction->setNewValue($value); $transaction->setNewValue($value);
break; break;
case ManiphestTransaction::TYPE_STATUS:
$phids = array();
$transaction->setOldvalue($task->getStatus());
$transaction->setNewValue($value);
break;
default: default:
$phids = array(); $phids = array();
$transaction->setNewValue($value); $transaction->setNewValue($value);