revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-20 20:40:56 +01:00
Code Issues Releases Wiki Activity

Remove "isUnparsed" flag from commits

Browse source 
Summary: The new "importStatus" property provides a much stronger and more consistent version of this flag. The only callsite was removed by D7452.

Test Plan: Used `grep` to check for callsites and found none.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7453
This commit is contained in:
epriestley 2013-10-30 13:06:57 -07:00
parent 25656b311a
commit d5bc8197ec
2 changed files with 2 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/diffusion/query/DiffusionQuery.php
View file

@ -99,8 +99,8 @@ abstract class DiffusionQuery extends PhabricatorQuery {
$commits = mpull($commits, null, 'getCommitIdentifier'); $commits = mpull($commits, null, 'getCommitIdentifier');
// Build empty commit objects for every commit, so we can show unparsed // Build empty commit objects for every commit, so we can show unparsed
// commits in history views as "unparsed" instead of not showing them. This // commits in history views (as "Importing") instead of not showing them.
// makes the process of importing and parsing commits much clearer to the // This makes the process of importing and parsing commits clearer to the
// user. // user.
$commit_list = array(); $commit_list = array();
@ -110,7 +110,6 @@ abstract class DiffusionQuery extends PhabricatorQuery {
$commit_obj = new PhabricatorRepositoryCommit(); $commit_obj = new PhabricatorRepositoryCommit();
$commit_obj->setRepositoryID($repository->getID()); $commit_obj->setRepositoryID($repository->getID());
$commit_obj->setCommitIdentifier($identifier); $commit_obj->setCommitIdentifier($identifier);
$commit_obj->setIsUnparsed(true);
$commit_obj->makeEphemeral(); $commit_obj->makeEphemeral();
} }
$commit_list[$identifier] = $commit_obj; $commit_list[$identifier] = $commit_obj;

10
src/applications/repository/storage/PhabricatorRepositoryCommit.php
View file

@ -25,7 +25,6 @@ final class PhabricatorRepositoryCommit
private $commitData = self::ATTACHABLE; private $commitData = self::ATTACHABLE;
private $audits; private $audits;
private $isUnparsed;
private $repository = self::ATTACHABLE; private $repository = self::ATTACHABLE;
public function attachRepository(PhabricatorRepository $repository) { public function attachRepository(PhabricatorRepository $repository) {
@ -37,15 +36,6 @@ final class PhabricatorRepositoryCommit
return $this->assertAttached($this->repository); return $this->assertAttached($this->repository);
} }
public function setIsUnparsed($is_unparsed) {
$this->isUnparsed = $is_unparsed;
return $this;
}
public function getIsUnparsed() {
return $this->isUnparsed;
}
public function isImported() { public function isImported() {
return ($this->getImportStatus() == self::IMPORTED_ALL); return ($this->getImportStatus() == self::IMPORTED_ALL);
} }