revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
Code Issues Releases Wiki Activity

Update people edit pages UI

Browse source 
Summary: Updates and clarifies UI

Test Plan: New peoples, new bots, new mailing list

Reviewers: epriestley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18562
This commit is contained in:
Chad Little 2017-09-07 11:49:10 -07:00
parent a5232e015a
commit d6bb0d1bfa
2 changed files with 7 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/people/controller/PhabricatorPeopleCreateController.php
View file

@ -92,13 +92,9 @@ final class PhabricatorPeopleCreateController
$crumbs->addTextCrumb($title); $crumbs->addTextCrumb($title);
$crumbs->setBorder(true); $crumbs->setBorder(true);
$header = id(new PHUIHeaderView())
->setHeader($title)
->setHeaderIcon('fa-user');
$box = id(new PHUIObjectBoxView()) $box = id(new PHUIObjectBoxView())
->setHeaderText(pht('User')) ->setHeaderText($title)
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
->setForm($form); ->setForm($form);
$guidance_context = new PhabricatorPeopleCreateGuidanceContext(); $guidance_context = new PhabricatorPeopleCreateGuidanceContext();
@ -109,7 +105,6 @@ final class PhabricatorPeopleCreateController
->newInfoView(); ->newInfoView();
$view = id(new PHUITwoColumnView()) $view = id(new PHUITwoColumnView())
->setHeader($header)
->setFooter( ->setFooter(
array( array(
$guidance, $guidance,

15
src/applications/people/controller/PhabricatorPeopleNewController.php
View file

@ -132,12 +132,15 @@ final class PhabricatorPeopleNewController
->setUser($admin); ->setUser($admin);
if ($is_bot) { if ($is_bot) {
$title = pht('Create New Bot');
$form->appendRemarkupInstructions( $form->appendRemarkupInstructions(
pht('You are creating a new **bot** user account.')); pht('You are creating a new **bot** user account.'));
} else if ($is_list) { } else if ($is_list) {
$title = pht('Create New Mailing List');
$form->appendRemarkupInstructions( $form->appendRemarkupInstructions(
pht('You are creating a new **mailing list** user account.')); pht('You are creating a new **mailing list** user account.'));
} else { } else {
$title = pht('Create New User');
$form->appendRemarkupInstructions( $form->appendRemarkupInstructions(
pht('You are creating a new **standard** user account.')); pht('You are creating a new **standard** user account.'));
} }
@ -205,25 +208,17 @@ final class PhabricatorPeopleNewController
"`bot@yourcompany.com` if you prefer.")); "`bot@yourcompany.com` if you prefer."));
} }
$title = pht('Create New User');
$box = id(new PHUIObjectBoxView()) $box = id(new PHUIObjectBoxView())
->setHeaderText(pht('User')) ->setHeaderText($title)
->setFormErrors($errors) ->setFormErrors($errors)
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
->setForm($form); ->setForm($form);
$crumbs = $this->buildApplicationCrumbs(); $crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb($title); $crumbs->addTextCrumb($title);
$crumbs->setBorder(true); $crumbs->setBorder(true);
$header = id(new PHUIHeaderView())
->setHeader($title)
->setHeaderIcon('fa-user');
$view = id(new PHUITwoColumnView()) $view = id(new PHUITwoColumnView())
->setHeader($header)
->setFooter($box); ->setFooter($box);
return $this->newPage() return $this->newPage()