Fixing some calendar event timeline issues.

Summary: Ref T7953, Fixing some calendar event timeline issues.

Test Plan: Create event, event timeline should reflect the transaction.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7953

Differential Revision: https://secure.phabricator.com/D12592

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

@@ -102,10 +102,6 @@ final class PhabricatorCalendarEventViewController
       ->setUser($viewer)
       ->setObject($event);
 
-    // $properties->addProperty(
-    //   pht('Name'),
-    //   $event->getName());
-
     $properties->addProperty(
       pht('Starts'),
       phabricator_datetime($event->getDateFrom(), $viewer));

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

@@ -43,7 +43,6 @@ final class PhabricatorCalendarEventTransaction
   public function shouldHide() {
     $old = $this->getOldValue();
     switch ($this->getTransactionType()) {
-      case self::TYPE_NAME:
       case self::TYPE_START_DATE:
       case self::TYPE_END_DATE:
       case self::TYPE_STATUS:
@@ -76,7 +75,11 @@ final class PhabricatorCalendarEventTransaction
     $type = $this->getTransactionType();
     switch ($type) {
       case self::TYPE_NAME:
-        if ($old) {
+        if ($old === null) {
+          return pht(
+            '%s created this event.',
+            $this->renderHandleLink($author_phid));
+        } else {
           return pht(
             '%s changed the name of this event from %s to %s.',
             $this->renderHandleLink($author_phid),