revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 06:20:56 +01:00
Code Issues Releases Wiki Activity

Hide skipped tests by default in Differential build result summary view

Browse source 
Summary: Ref T8096. Currently, we hide passing tests by default (they aren't interesting) but should also hide skipped tests by default (they aren't interesting either).

Test Plan: {F694485}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8096

Differential Revision: https://secure.phabricator.com/D13821
This commit is contained in:
epriestley 2015-08-08 07:43:08 -07:00
parent 79f2e81f38
commit da1e711abb
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/applications/differential/customfield/DifferentialUnitField.php
View file

@ -56,8 +56,14 @@ final class DifferentialUnitField
protected function newHarbormasterMessageView(array $messages) { protected function newHarbormasterMessageView(array $messages) {
foreach ($messages as $key => $message) { foreach ($messages as $key => $message) {
if ($message->getResult() == ArcanistUnitTestResult::RESULT_PASS) { switch ($message->getResult()) {
unset($messages[$key]); case ArcanistUnitTestResult::RESULT_PASS:
case ArcanistUnitTestResult::RESULT_SKIP:
// Don't show "Pass" or "Skip" in the UI since they aren't very
// interesting. The user can click through to the full results if
// they want details.
unset($messages[$key]);
break;
} }
} }