mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-24 06:20:56 +01:00
Hide skipped tests by default in Differential build result summary view
Summary: Ref T8096. Currently, we hide passing tests by default (they aren't interesting) but should also hide skipped tests by default (they aren't interesting either). Test Plan: {F694485} Reviewers: chad Reviewed By: chad Maniphest Tasks: T8096 Differential Revision: https://secure.phabricator.com/D13821
This commit is contained in:
parent
79f2e81f38
commit
da1e711abb
1 changed files with 8 additions and 2 deletions
|
@ -56,8 +56,14 @@ final class DifferentialUnitField
|
|||
|
||||
protected function newHarbormasterMessageView(array $messages) {
|
||||
foreach ($messages as $key => $message) {
|
||||
if ($message->getResult() == ArcanistUnitTestResult::RESULT_PASS) {
|
||||
switch ($message->getResult()) {
|
||||
case ArcanistUnitTestResult::RESULT_PASS:
|
||||
case ArcanistUnitTestResult::RESULT_SKIP:
|
||||
// Don't show "Pass" or "Skip" in the UI since they aren't very
|
||||
// interesting. The user can click through to the full results if
|
||||
// they want details.
|
||||
unset($messages[$key]);
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue