revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exceptions on History page of Diffusion repo after changing text encoding

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=97e163187418), phorge(head=master, ref.master=108cbcd09bd3)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php:20]
```

Closes T15460

Test Plan: After applying these two changes, changing the text encoding of a Diffusion repository to a valid encoding and going to `/diffusion/1/manage/history/`, page renders correctly and shows no exception.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15460

Differential Revision: https://we.phorge.it/D25284
This commit is contained in:
Andre Klapper 2023-06-12 03:49:19 +02:00
parent 331b9cca42
commit db19b23dce
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/repository/xaction/PhabricatorRepositoryEncodingTransaction.php
View file

@ -17,12 +17,12 @@ final class PhabricatorRepositoryEncodingTransaction
$old = $this->getOldValue(); $old = $this->getOldValue();
$new = $this->getNewValue(); $new = $this->getNewValue();
if (strlen($old) && !strlen($new)) { if ($old !== null && $new === null) {
return pht( return pht(
'%s removed the %s encoding configured for this repository.', '%s removed the %s encoding configured for this repository.',
$this->renderAuthor(), $this->renderAuthor(),
$this->renderOldValue()); $this->renderOldValue());
} else if (strlen($new) && !strlen($old)) { } else if ($new !== null && $old === null) {
return pht( return pht(
'%s set the encoding for this repository to %s.', '%s set the encoding for this repository to %s.',
$this->renderAuthor(), $this->renderAuthor(),