revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Make the 'Subscribe' button pop a modal instead.

Browse source 
Summary:
See title.

Also some minor styling/consistency fixes.

Test Plan:
- Clicked subscribe
- Canceled to make sure it went away
- Clicked it again
- Clicked subscribe
- Saw my name in the cc field.

Reviewers: epriestley, chad, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4571
This commit is contained in:
Ricky Elrod 2013-01-21 18:41:38 -08:00 committed by epriestley
parent baa9d96082
commit dce6d2e9d5
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/applications/differential/controller/DifferentialRevisionViewController.php
View file

@ -60,10 +60,11 @@ final class DifferentialRevisionViewController extends DifferentialController {
$repository); $repository);
if ($request->getExists('download')) { if ($request->getExists('download')) {
return $this->buildRawDiffResponse($changesets, return $this->buildRawDiffResponse(
$vs_changesets, $changesets,
$vs_map, $vs_changesets,
$repository); $vs_map,
$repository);
} }
$props = id(new DifferentialDiffProperty())->loadAllWhere( $props = id(new DifferentialDiffProperty())->loadAllWhere(
@ -163,8 +164,8 @@ final class DifferentialRevisionViewController extends DifferentialController {
phutil_render_tag( phutil_render_tag(
'p', 'p',
array(), array(),
pht('This revision has no specified reviewers and needs review.'. pht('This revision has no specified reviewers and needs '.
' You may want to add some reviewers.') 'review. You may want to add some reviewers.')
)); ));
} }
} }
@ -495,6 +496,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
'href' => "/differential/subscribe/{$action}/{$revision_id}/", 'href' => "/differential/subscribe/{$action}/{$revision_id}/",
'name' => $viewer_is_cc ? 'Unsubscribe' : 'Subscribe', 'name' => $viewer_is_cc ? 'Unsubscribe' : 'Subscribe',
'instant' => true, 'instant' => true,
'sigil' => 'workflow',
); );
} else { } else {
$links[] = array( $links[] = array(