1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-10 14:51:06 +01:00

Add an explicit "null" to a missed diffusion.branchquery callsite to fix Diffusion "Branches" page

Summary:
See PHI775. See D19499. Originally, see PHI720.

D19499 broke the standalone "Branches" page for commits. Normally, you reach this by taking these steps:

  - View a commit which is contained by 11 or more branches.
  - Click the "More Branches..." link in the "Branches" field.
  - You should be taken to a list of all branches which contain the commit.

The change to the 'branch' parameter was adjusted in the query that builds the "x, y, z, More Branches..." list, but not on the actual "Branches" list with the full list. Adjust it.

Test Plan:
  - Set display limit to 1, viewed a commit on "master" and "stable", clicked "More Branches".
  - Before: saw only "master".
  - After: saw both "master" and "stable".

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19532
This commit is contained in:
epriestley 2018-07-21 05:39:27 -07:00
parent 96a8b89fa8
commit dce6dd5d02

View file

@ -22,6 +22,7 @@ final class DiffusionBranchTableController extends DiffusionController {
$params = array(
'offset' => $pager->getOffset(),
'limit' => $pager->getPageSize() + 1,
'branch' => null,
);
$contains = $drequest->getSymbolicCommit();