1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00

Application Search - fix error updating searches from human-readable links

Summary:
Fixes T5666. When we have a pretty link right now it can conflict with form data; e.g. if you have 'statuses=open' in the URI and then uncheck status = open in the UI, you will still get the open status in the next search.

To fix this, set the form action explicitly to lose all the get parameter junk.

Test Plan: tried the test case in T5666 / this description and it no longer failed...!

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5666

Differential Revision: https://secure.phabricator.com/D10115
This commit is contained in:
Bob Trahan 2014-08-01 17:22:24 -07:00
parent e50b269416
commit dd918b0d14

View file

@ -153,7 +153,8 @@ final class PhabricatorApplicationSearchController
'query/advanced'); 'query/advanced');
$form = id(new AphrontFormView()) $form = id(new AphrontFormView())
->setUser($user); ->setUser($user)
->setAction($request->getPath());
$engine->buildSearchForm($form, $saved_query); $engine->buildSearchForm($form, $saved_query);