1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-10 23:01:04 +01:00

Unrequire filling Owners in Owners tool

Summary:
Owners field is filled by Primary Owner which is required.
So that it is not neccessary to require filling Owners explicitly.

Test Plan: Don't fill Owners and successfully save the form //before// this change.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Differential Revision: https://secure.phabricator.com/D2201
This commit is contained in:
vrana 2012-04-10 17:14:53 -07:00
parent 2360504462
commit dea4901bb6

View file

@ -41,7 +41,6 @@ final class PhabricatorOwnersEditController
$e_name = true; $e_name = true;
$e_primary = true; $e_primary = true;
$e_owners = true;
$errors = array(); $errors = array();
@ -88,13 +87,6 @@ final class PhabricatorOwnersEditController
$e_primary = null; $e_primary = null;
} }
if (!$owners) {
$e_owners = 'Required';
$errors[] = 'Package must have at least one owner.';
} else {
$e_owners = null;
}
if (!$path_refs) { if (!$path_refs) {
$errors[] = 'Package must include at least one path.'; $errors[] = 'Package must include at least one path.';
} }
@ -214,8 +206,7 @@ final class PhabricatorOwnersEditController
->setDatasource('/typeahead/common/usersorprojects/') ->setDatasource('/typeahead/common/usersorprojects/')
->setLabel('Owners') ->setLabel('Owners')
->setName('owners') ->setName('owners')
->setValue($token_all_owners) ->setValue($token_all_owners))
->setError($e_owners))
->appendChild( ->appendChild(
id(new AphrontFormSelectControl()) id(new AphrontFormSelectControl())
->setName('auditing') ->setName('auditing')