revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-31 09:50:59 +01:00
Code Issues Releases Wiki Activity

Don't output empty summary in e-mails

Browse source 
Summary:
Reviews with empty summary are rendered like this:

  Reviewers: ...

  TEST PLAN

Test Plan:
Use empty summary.
Use non-empty summary.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1528
This commit is contained in:
vrana 2012-01-31 10:30:40 -08:00
parent 7bee68a763
commit deed4ffed0
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/differential/mail/reviewrequest/DifferentialReviewRequestMail.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -50,8 +50,10 @@ abstract class DifferentialReviewRequestMail extends DifferentialMail {
$body = array(); $body = array();
if ($this->isFirstMailToRecipients()) { if ($this->isFirstMailToRecipients()) {
if ($revision->getSummary() != '') {
$body[] = $this->formatText($revision->getSummary()); $body[] = $this->formatText($revision->getSummary());
$body[] = null; $body[] = null;
}
$body[] = 'TEST PLAN'; $body[] = 'TEST PLAN';
$body[] = $this->formatText($revision->getTestPlan()); $body[] = $this->formatText($revision->getTestPlan());