revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 20:10:55 +01:00
Code Issues Releases Wiki Activity

Silence a warning about unknown fields in 'getcommitmessage'

Browse source 
Summary: Similar to D8491, some of my new exceptions are a bit too aggressive. See IRC. This one's hitting an edit workflow with 'revisionID' onboard somehow.

Test Plan: Not entirely sure how to hit this, but it won't throw anymore.

Reviewers: btrahan, dctrwatson, zeeg

Reviewed By: zeeg

Subscribers: zeeg, aran, epriestley

Differential Revision: https://secure.phabricator.com/D8514
This commit is contained in:
epriestley 2014-03-12 17:24:58 -07:00
parent 3f7f5a47ff
commit e068b04b5c
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/differential/conduit/ConduitAPI_differential_getcommitmessage_Method.php
View file

@ -65,11 +65,9 @@ final class ConduitAPI_differential_getcommitmessage_Method
foreach ($fields as $field => $value) { foreach ($fields as $field => $value) {
$custom_field = idx($field_map, $field); $custom_field = idx($field_map, $field);
if (!$custom_field) { if (!$custom_field) {
throw new Exception( // Just ignore this, these workflows don't make strong distictions
pht( // about field editability on the client side.
'Commit message includes field "%s", but this field does not '. continue;
'correspond to a known field.',
$field));
} }
if ($is_create || if ($is_create ||
$custom_field->shouldOverwriteWhenCommitMessageIsEdited()) { $custom_field->shouldOverwriteWhenCommitMessageIsEdited()) {