revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-23 05:01:13 +01:00
Code Issues Releases Wiki Activity

Fix 'Add to Dashboard' issue with builtins

Browse source 
Summary: Ref T5307. Actually check the built in query with query, not engine.

Test Plan: Try a builtin query, and a custom query when making a dashboard panel.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T5307

Differential Revision: https://secure.phabricator.com/D17521
This commit is contained in:
Chad Little 2017-03-20 15:02:52 -07:00
parent 9b07adb8da
commit e69f8f717b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php
View file

@ -29,7 +29,7 @@ final class PhabricatorDashboardQueryPanelInstallController
$engine = $engines[$v_engine]; $engine = $engines[$v_engine];
$engine->setViewer($viewer); $engine->setViewer($viewer);
$good_query = false; $good_query = false;
if ($engine->isBuiltinQuery($v_engine)) { if ($engine->isBuiltinQuery($v_query)) {
$good_query = true; $good_query = true;
} else { } else {
$saved_query = id(new PhabricatorSavedQueryQuery()) $saved_query = id(new PhabricatorSavedQueryQuery())