revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-15 09:11:07 +01:00
Code Issues Releases Wiki Activity

Alternate fix for Firefox triple click selection

Browse source 
Summary:
Fixes T10905. This reverts D15823, which didn't work well for tasks with very long titles (the title would break as a block element).

This is slightly more magic but works with long titles.

Test Plan: Did everything from D15823, but also with long titles. Triple-click, wrapping, and mobile/device worked in Safari, Firefox and Chrome.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10905

Differential Revision: https://secure.phabricator.com/D15824
This commit is contained in:
epriestley 2016-04-29 16:52:27 -07:00
parent 06abeb2010
commit e8dca5a4f9
3 changed files with 6 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/celerity/map.php
View file

@ -7,7 +7,7 @@
*/ */
return array( return array(
'names' => array( 'names' => array(
'core.pkg.css' => 'ede6bf7a', 'core.pkg.css' => 'b729f9f5',
'core.pkg.js' => '6972d365', 'core.pkg.js' => '6972d365',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '7ba78475', 'differential.pkg.css' => '7ba78475',
@ -136,7 +136,7 @@ return array(
'rsrc/css/phui/phui-form-view.css' => '6a51768e', 'rsrc/css/phui/phui-form-view.css' => '6a51768e',
'rsrc/css/phui/phui-form.css' => 'aac1d51d', 'rsrc/css/phui/phui-form.css' => 'aac1d51d',
'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f', 'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f',
'rsrc/css/phui/phui-header-view.css' => '9961e480', 'rsrc/css/phui/phui-header-view.css' => '4c7dd8f5',
'rsrc/css/phui/phui-hovercard.css' => 'de1a2119', 'rsrc/css/phui/phui-hovercard.css' => 'de1a2119',
'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad', 'rsrc/css/phui/phui-icon-set-selector.css' => '1ab67aad',
'rsrc/css/phui/phui-icon.css' => '3f33ab57', 'rsrc/css/phui/phui-icon.css' => '3f33ab57',
@ -829,7 +829,7 @@ return array(
'phui-form-css' => 'aac1d51d', 'phui-form-css' => 'aac1d51d',
'phui-form-view-css' => '6a51768e', 'phui-form-view-css' => '6a51768e',
'phui-head-thing-view-css' => 'fd311e5f', 'phui-head-thing-view-css' => 'fd311e5f',
'phui-header-view-css' => '9961e480', 'phui-header-view-css' => '4c7dd8f5',
'phui-hovercard' => '1bd28176', 'phui-hovercard' => '1bd28176',
'phui-hovercard-view-css' => 'de1a2119', 'phui-hovercard-view-css' => 'de1a2119',
'phui-icon-set-selector-css' => '1ab67aad', 'phui-icon-set-selector-css' => '1ab67aad',

9
src/view/phui/PHUIHeaderView.php
View file

@ -316,15 +316,6 @@ final class PHUIHeaderView extends AphrontTagView {
$header_content); $header_content);
} }
// This wrapper element allows titles to be triple-clicked to select them
// in Firefox. See T10905 for discussion.
$header_content = phutil_tag(
'span',
array(
'class' => 'phui-header-content',
),
$header_content);
$left[] = phutil_tag( $left[] = phutil_tag(
'span', 'span',
array( array(

6
webroot/rsrc/css/phui/phui-header-view.css
View file

@ -78,10 +78,10 @@ body .phui-header-shell.phui-bleed-header
.phui-header-header .phui-header-icon { .phui-header-header .phui-header-icon {
margin-right: 8px; margin-right: 8px;
color: {$lightbluetext}; color: {$lightbluetext};
}
.phui-header-content { /* This allows the header text to be triple-clicked to select it in Firefox,
display: inline-block; see T10905 for discussion. */
display: inline;
} }
.phui-object-box .phui-header-tall .phui-header-header, .phui-object-box .phui-header-tall .phui-header-header,