revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-01 18:30:59 +01:00
Code Issues Releases Wiki Activity

Fix an issue with multiple "open" statuses and the "View All" button on Projects

Browse source 
Summary: See IRC. We construct this a little bit wrong if there are multiple "open" statuses. Use a more modern construction.

Test Plan: Hit `?statuses=wontfix,invalid`, etc. Clicked "view all" from projects.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D8854
This commit is contained in:
epriestley 2014-04-24 10:35:28 -07:00
parent 2ac8457cb9
commit ea66aead59
2 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/applications/maniphest/query/ManiphestTaskSearchEngine.php
View file

@ -24,8 +24,14 @@ final class ManiphestTaskSearchEngine
'subscriberPHIDs', 'subscriberPHIDs',
$this->readPHIDsFromRequest($request, 'subscribers')); $this->readPHIDsFromRequest($request, 'subscribers'));
$saved->setParameter('statuses', $request->getArr('statuses')); $saved->setParameter(
$saved->setParameter('priorities', $request->getArr('priorities')); 'statuses',
$this->readListFromRequest($request, 'statuses'));
$saved->setParameter(
'priorities',
$this->readListFromRequest($request, 'priorities'));
$saved->setParameter('group', $request->getStr('group')); $saved->setParameter('group', $request->getStr('group'));
$saved->setParameter('order', $request->getStr('order')); $saved->setParameter('order', $request->getStr('order'));

4
src/applications/project/controller/PhabricatorProjectProfileController.php
View file

@ -147,8 +147,8 @@ final class PhabricatorProjectProfileController
$task_list->setHandles($handles); $task_list->setHandles($handles);
$phid = $project->getPHID(); $phid = $project->getPHID();
$view_uri = sprintf( $view_uri = urisprintf(
'/maniphest/?statuses[]=%s&allProjects[]=%s#R', '/maniphest/?statuses=%s&allProjects[]=%s#R',
implode(',', ManiphestTaskStatus::getOpenStatusConstants()), implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
$phid); $phid);
$create_uri = '/maniphest/task/create/?projects='.$phid; $create_uri = '/maniphest/task/create/?projects='.$phid;