revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Remove "phlog()" of exeptions during Conduit calls

Browse source 
Summary: Fixes T13465. This "phlog()" made some degree of sense at one time, but is no longer useful or consistent. Get rid of it. See T13465 for discussion.

Test Plan: Made a conduit call that hit a policy error, no longer saw error in log.

Maniphest Tasks: T13465

Differential Revision: https://secure.phabricator.com/D20924
This commit is contained in:
epriestley 2019-11-22 11:53:06 -08:00
parent 2abf292821
commit eb6df7a209
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/conduit/controller/PhabricatorConduitAPIController.php
View file

@ -99,9 +99,6 @@ final class PhabricatorConduitAPIController
list($error_code, $error_info) = $auth_error; list($error_code, $error_info) = $auth_error;
} }
} catch (Exception $ex) { } catch (Exception $ex) {
if (!($ex instanceof ConduitMethodNotFoundException)) {
phlog($ex);
}
$result = null; $result = null;
$error_code = ($ex instanceof ConduitException $error_code = ($ex instanceof ConduitException
? 'ERR-CONDUIT-CALL' ? 'ERR-CONDUIT-CALL'