revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
Code Issues Releases Wiki Activity

Fix a variable typo which prevents metadata from attaching to @mention

Browse source 
Differential comments

Summary: If you @mention several users, at least one of which is already CC'd,
we unset all the CCs and don't attach the "Added CCs: ..." block to the comment.

Test Plan: @mentioned two users, one of whom was already CC'd.

Reviewers: jungejason, tuomaspelkonen, aran

Reviewed By: jungejason

CC: aran, jungejason

Differential Revision: 827
This commit is contained in:
epriestley 2011-08-18 07:32:08 -07:00
parent 0be3db03ee
commit ebdd6d3d11
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/editor/comment/DifferentialCommentEditor.php
View file

@ -351,7 +351,7 @@ class DifferentialCommentEditor {
$current_ccs = array_fill_keys($current_ccs, true); $current_ccs = array_fill_keys($current_ccs, true);
foreach ($mention_ccs as $key => $mention_cc) { foreach ($mention_ccs as $key => $mention_cc) {
if (isset($current_ccs[$mention_cc])) { if (isset($current_ccs[$mention_cc])) {
unset($mention_ccs); unset($mention_ccs[$key]);
} }
} }
} }