revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
Code Issues Releases Wiki Activity

Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly

Browse source 
Summary: Depends on D19310. Ref T13105. The "meta" value was not populating correctly because this used `phutil_tag()`.

Test Plan: Will verify on `secure`.

Maniphest Tasks: T13105

Differential Revision: https://secure.phabricator.com/D19311
This commit is contained in:
epriestley 2018-04-09 05:18:58 -07:00
parent 11664277b3
commit eca7dc25f2
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/applications/diffusion/controller/DiffusionBlameController.php
View file

@ -145,9 +145,9 @@ final class DiffusionBlameController extends DiffusionController {
'href' => $commit->getURI(), 'href' => $commit->getURI(),
'sigil' => 'has-tooltip', 'sigil' => 'has-tooltip',
'meta' => array( 'meta' => array(
'tip' => $this->renderCommitTooltip($commit, $handles), 'tip' => $this->renderCommitTooltip($commit, $handles),
'align' => 'E', 'align' => 'E',
'size' => 600, 'size' => 600,
), ),
), ),
$commit->getLocalName()); $commit->getLocalName());
@ -158,20 +158,19 @@ final class DiffusionBlameController extends DiffusionController {
); );
if ($revision) { if ($revision) {
$revision_link = phutil_tag( $revision_link = javelin_tag(
'a', 'a',
array( array(
'href' => $revision->getURI(), 'href' => $revision->getURI(),
'sigil' => 'has-tooltip', 'sigil' => 'has-tooltip',
'meta' => array( 'meta' => array(
'tip' => $this->renderRevisionTooltip($revision, $handles), 'tip' => $this->renderRevisionTooltip($revision, $handles),
'align' => 'E', 'align' => 'E',
'size' => 600, 'size' => 600,
), ),
), ),
$revision->getMonogram()); $revision->getMonogram());
$info = array( $info = array(
$info, $info,
' / ', ' / ',