revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

Remove another old remarkup engine callsite in Config

Browse source 
Summary: Ref T13189. Summaries do not appear to be meaningfully rendered with Remarkup so just drop the engine. See D19610 for the previous change in this vein.

Test Plan: Viewed config list with option summaries.

Reviewers: amckinley

Maniphest Tasks: T13189

Differential Revision: https://secure.phabricator.com/D19612
This commit is contained in:
epriestley 2018-08-27 10:48:08 -07:00
parent 415de4ce37
commit ee823982a4
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/config/controller/PhabricatorConfigGroupController.php
View file

@ -60,17 +60,10 @@ final class PhabricatorConfigGroupController
$db_values = mpull($db_values, null, 'getConfigKey'); $db_values = mpull($db_values, null, 'getConfigKey');
} }
$engine = id(new PhabricatorMarkupEngine())
->setViewer($this->getRequest()->getUser());
foreach ($options as $option) {
$engine->addObject($option, 'summary');
}
$engine->process();
$list = new PHUIObjectItemListView(); $list = new PHUIObjectItemListView();
$list->setBig(true); $list->setBig(true);
foreach ($options as $option) { foreach ($options as $option) {
$summary = $engine->getOutput($option, 'summary'); $summary = $option->getSummary();
$item = id(new PHUIObjectItemView()) $item = id(new PHUIObjectItemView())
->setHeader($option->getKey()) ->setHeader($option->getKey())