revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-30 01:10:58 +01:00
Code Issues Releases Wiki Activity

Add abstract getGroup() method

Browse source 
Summary: In D11722, a `getGroup()` method was added to all subclasses of `PhabricatorApplicationConfigOptions`, but no abstract method was added to the base class. This will fail if a custom `*ConfigOptions` class does not provide a `getGroup()` method, in which case `$group->getGroup()` (in `PhabricatorConfigListController`) will fatal.

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11756
This commit is contained in:
Joshua Spence 2015-03-01 09:47:10 +11:00
parent ea337abafb
commit eec2d145df
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/config/option/PhabricatorApplicationConfigOptions.php
View file

@ -4,6 +4,7 @@ abstract class PhabricatorApplicationConfigOptions extends Phobject {
abstract public function getName(); abstract public function getName();
abstract public function getDescription(); abstract public function getDescription();
abstract public function getGroup();
abstract public function getOptions(); abstract public function getOptions();
public function getFontIcon() { public function getFontIcon() {