revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
Code Issues Releases Wiki Activity

Stop advising users to use npm -g to install websockets

Browse source 
Summary: Fixes T6910. This advice is bad, doesn't work, and was based on me havng an outdated or incorrect understanding of Node and npm.

Test Plan: Read documentation.

Reviewers: richardvanvelzen, btrahan, chad, joshuaspence

Reviewed By: chad, joshuaspence

Subscribers: epriestley

Maniphest Tasks: T6910

Differential Revision: https://secure.phabricator.com/D11285
This commit is contained in:
epriestley 2015-01-08 14:02:14 -08:00
parent 5c25f38038
commit f0ade1be1c
2 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/docs/user/configuration/notifications.diviner
View file

@ -41,16 +41,10 @@ The notification server uses Node.js, so you'll need to install it first.
To install Node.js, follow the instructions on To install Node.js, follow the instructions on
[[ http://nodejs.org | nodejs.org ]]. [[ http://nodejs.org | nodejs.org ]].
You will also need to install the `ws` module for Node. After installing You will also need to install the `ws` module for Node. This needs to be
Node, run `npm install -g ws` to install it. installed into the notification server directory:
name="(Option 1, Recommended) Install 'ws' Module Globally" phabricator/ $ cd support/aphlict/server/
$ npm install -g ws # Global Install
If you prefer, you can also install it locally in the `support/aphlict/server/`
directory:
name="(Option 2) Install 'ws' Module Locally"
phabricator/support/aphlict/server/ $ npm install ws phabricator/support/aphlict/server/ $ npm install ws
Once Node.js and the `ws` module are installed, you're ready to start the Once Node.js and the `ws` module are installed, you're ready to start the

3
support/aphlict/server/aphlict_server.js
View file

@ -52,7 +52,8 @@ try {
} catch (ex) { } catch (ex) {
throw new Error( throw new Error(
'You need to install the Node.js "ws" module for websocket support. ' + 'You need to install the Node.js "ws" module for websocket support. ' +
'Usually, you can do this with `npm install -g ws`. ' + ex.toString()); 'See "Notifications User Guide: Setup and Configuration" in the ' +
'documentation for instructions. ' + ex.toString());
} }
var ssl_config = { var ssl_config = {