mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-22 21:40:55 +01:00
The existing Audit code forgot to set authorPHID
Summary: The audit tools has many false positive about Author Not Matching with Revision. The fix is to set the authorPHID which was missing in the existing code Test Plan: run reparse.php and it doesn't generate false positive result anymore. Reviewers: nh, epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2119
This commit is contained in:
parent
f7c74e3fb8
commit
f6748bc190
1 changed files with 1 additions and 0 deletions
|
@ -111,6 +111,7 @@ final class PhabricatorRepositoryCommitOwnersWorker
|
|||
$revision_author_phid = $revision->getAuthorPHID();
|
||||
$revision_reviewedby_phid = $revision->loadReviewedBy();
|
||||
$commit_reviewedby_phid = $data->getCommitDetail('reviewerPHID');
|
||||
$commit_author_phid = $data->getCommitDetail('authorPHID');
|
||||
if ($revision_author_phid !== $commit_author_phid) {
|
||||
$reasons[] = "Author Not Matching with Revision";
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue