revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

Mangle cells that look a little bit like formulas in CSV files

Browse source 
Summary:
Fixes T12800. See that task for discussion. When a cell in a CSV begins with "=", "+", "-", or "@", mangle the content to discourage Excel from executing it.

This is clumsy, but we support other formats (e.g., JSON) which preserve the data faithfully and you should probably be using JSON if you're going to do anything programmatic with it.

We could add two formats or a checkbox or a warning or something but cells with these symbols are fairly rare anyway.

Some possible exceptions I can think of are "user monograms" (but we don't export those right now) and "negative numbers" (but also no direct export today). We can add exceptions for those as they arise.

Test Plan: Exported a task named `=cmd|'/C evil.exe'!A0`, saw the title get mangled with "(!)" in front.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T12800

Differential Revision: https://secure.phabricator.com/D18974
This commit is contained in:
epriestley 2018-01-30 15:58:05 -08:00
parent c9df8f77c8
commit f9336e5694
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/infrastructure/export/format/PhabricatorCSVExportFormat.php
View file

@ -42,6 +42,16 @@ final class PhabricatorCSVExportFormat
private function addRow(array $values) { private function addRow(array $values) {
$row = array(); $row = array();
foreach ($values as $value) { foreach ($values as $value) {
// Excel is extremely interested in executing arbitrary code it finds in
// untrusted CSV files downloaded from the internet. When a cell looks
// like it might be too tempting for Excel to ignore, mangle the value
// to dissuade remote code execution. See T12800.
if (preg_match('/^\s*[+=@-]/', $value)) {
$value = '(!) '.$value;
}
if (preg_match('/\s|,|\"/', $value)) { if (preg_match('/\s|,|\"/', $value)) {
$value = str_replace('"', '""', $value); $value = str_replace('"', '""', $value);
$value = '"'.$value.'"'; $value = '"'.$value.'"';