revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-10 23:01:04 +01:00
Code Issues Releases Wiki Activity

Ignore #hashtag implicit project tags which have no effect

Browse source 
Summary:
Fixes T5489. Currently, if you make a `#proj` comment on an object already tagged with `#proj`, you get a "no effect" dialog.

Instead, continue if these transactions produce no effect (this is normal/expected, and consistent with `@user`).

Test Plan: Made two `#proj` comments in a row on a revision.

Reviewers: joshuaspence, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5489

Differential Revision: https://secure.phabricator.com/D9745
This commit is contained in:
epriestley 2014-06-26 14:07:10 -07:00
parent d541664956
commit f967678236
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
View file

@ -1131,6 +1131,7 @@ abstract class PhabricatorApplicationTransactionEditor
if ($phids) {
$edge_type = PhabricatorEdgeConfig::TYPE_OBJECT_HAS_PROJECT;
$block_xactions[] = newv(get_class(head($xactions)), array())
->setIgnoreOnNoEffect(true)
->setTransactionType(PhabricatorTransactions::TYPE_EDGE)
->setMetadataValue('edge:type', $edge_type)
->setNewValue(array('+' => $phids));