revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

When sorting subscriber references for display in the curtain UI, sort without case sensitivity

Browse source 
Summary: Ref T13486. Currently, "Zarbo" sorts above "alice", but this isn't expected for a list of (mostly) human usernames.

Test Plan: Loaded a task with subscribers with mixed-case usernames.

Maniphest Tasks: T13486

Differential Revision: https://secure.phabricator.com/D20969
This commit is contained in:
epriestley 2020-02-04 15:03:17 -08:00
parent fdbe9ba149
commit fd46c597ae
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/subscriptions/engineextension/PhabricatorSubscriptionsCurtainExtension.php
View file

@ -123,7 +123,9 @@ final class PhabricatorSubscriptionsCurtainExtension
$handle = $handles[$subscriber_phid]; $handle = $handles[$subscriber_phid];
if ($handle->isComplete()) { if ($handle->isComplete()) {
$is_complete = true; $is_complete = true;
$sort_name = $handle->getLinkName(); $sort_name = $handle->getLinkName();
$sort_name = phutil_utf8_strtolower($sort_name);
} }
} }
} }