revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 21:40:55 +01:00
Code Issues Releases Wiki Activity

Slightly loosen the mention regexp to allow for "Go ask @tomo."

Browse source 
Summary: Currently, we incorrectly flag these under the "@lists.com" rule.
Test Plan:
https://secure.phabricator.com/file/view/PHID-FILE-887c2bc66eb9d47d02f4/
Reviewed By: tomo
Reviewers: tomo
CC: aran, epriestley, tomo
Differential Revision: 708
This commit is contained in:
epriestley 2011-07-21 16:26:51 -07:00
parent ef89340aa9
commit ffae7b19e6
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/infrastructure/markup/remarkup/markuprule/mention/PhabricatorRemarkupRuleMention.php
View file

@ -29,8 +29,9 @@ class PhabricatorRemarkupRuleMention
// NOTE: Negative lookahead for period prevents us from picking up email // NOTE: Negative lookahead for period prevents us from picking up email
// addresses, while allowing constructs like "@tomo, lol". The negative // addresses, while allowing constructs like "@tomo, lol". The negative
// lookbehind for a word character prevents us from matching "mail@lists" // lookbehind for a word character prevents us from matching "mail@lists"
// while allowing "@tomo/@mroch". // while allowing "@tomo/@mroch". The negative lookahead prevents us from
$regexp = '/(?<!\w)@([a-zA-Z0-9]+)\b(?![.])/'; // matching "@joe.com" while allowing us to match "hey, @joe.".
$regexp = '/(?<!\w)@([a-zA-Z0-9]+)\b(?![.]\w)/';
$matches = null; $matches = null;
$ok = preg_match_all($regexp, $text, $matches); $ok = preg_match_all($regexp, $text, $matches);