4 commits

Author	SHA1	Message	Date
epriestley	d0af617818	Add "final" to (almost) everything else ... Summary: Last of the big final patches. Left a few debatable classes (12 out of about 400) that I'll deal with individually eventually. Test Plan: Ran testEverythingImplemented. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T795 Differential Revision: https://secure.phabricator.com/D1881	2012-03-13 16:21:04 -07:00
epriestley	b2890eeb0e	Add "final" to all Phabricator "Controller" classes ... Summary: These are all unambiguously unextensible. Issues I hit: - Maniphest Change/Diff controllers, just consolidated them. - Some search controllers incorrectly extend from "Search" but should extend from "SearchBase". This has no runtime effects. - D1836 introduced a closure, which we don't handle correctly (somewhat on purpose; we target PHP 5.2). See T962. Test Plan: Ran "testEverythingImplemented" unit test to identify classes extending from `final` classes. Resolved issues. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T795 Differential Revision: https://secure.phabricator.com/D1843	2012-03-09 15:46:25 -08:00
epriestley	361ec78b03	Add missing includes from XHPAST parse bug.	2011-04-06 23:14:58 -07:00
epriestley	aa0ff43999	xhpastview	2011-04-06 22:43:56 -07:00