vrana
49f75d2554
Don't store empty copy:lines
...
Summary: The [[ https://secure.phabricator.com/diffusion/P/browse/master/src/applications/differential/parser/DifferentialChangesetParser.php;8d0918885da2c22b$1364 | callsite ]] is fine with that.
Test Plan: This diff.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D3537
2012-09-21 15:22:07 -07:00
dschleimer
86fa4fd97f
[Phabricator] track Mercurial bookmarks for differential diffs
...
Summary:
This adds all the changes necessary to track the active Mercurial
bookmark for differential diffs. We render both branch and bookmark
information in the branch field of the Differential revison view, as
seen in
https://secure.phabricator.com/file/data/kzpmu3evfkukxdjyxrfz/PHID-FILE-eqorsqupxvwirqi2s5lo/bookmark_differential.jpg
The Arcanist half of this is https://secure.phabricator.com/D2896
Test Plan:
Mostly D2896 .
Additionally, loaded a diff created with a bookmark, as per the link in the summary.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T1331
Differential Revision: https://secure.phabricator.com/D2897
2012-06-30 15:41:58 -07:00
vrana
6c1c3c3a7a
Fix line count in diffs with more hunks per changeset
...
Summary: This error usually doesn't occur because we have only one hunk per changeset most of the time.
Test Plan:
$hunk = new ArcanistDiffHunk();
$hunk->setAddLines(1);
$hunk->setDelLines(1);
$change = new ArcanistDiffChange();
$change->addHunk($hunk);
$change->addHunk($hunk);
$diff = DifferentialDiff::newFromRawChanges(array($change));
var_dump($diff->getLineCount());
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D2878
2012-06-27 18:09:40 -07:00
epriestley
d4b6b095cb
Provide a script to completely destroy revisions
...
Summary:
Someone may or may not have accidentally uploaded secrets to Differential. Provide an administrative mechanism to permanently destroy a revision.
Also fix some of the transaction handling code.
Test Plan:
$ ./scripts/differential/destroy_revision.php --trace D1
>>> [0] <connect>
<<< [0] <connect> 1,060 us
>>> [1] <query> SELECT * FROM `differential_revision` WHERE `id` = 1
<<< [1] <query> 473 us
Really destroy 'D1 : asdbas' forever? [y/N] y
>>> [2] <connect>
<<< [2] <connect> 628 us
>>> [3] <query> START TRANSACTION
<<< [3] <query> 190 us
>>> [4] <query> SELECT * FROM `differential_diff` WHERE revisionID = 1
<<< [4] <query> 510 us
>>> [5] <query> SAVEPOINT Aphront_Savepoint_1
<<< [5] <query> 122 us
>>> [6] <query> SELECT * FROM `differential_changeset` WHERE diffID = 1
<<< [6] <query> 307 us
>>> [7] <query> SAVEPOINT Aphront_Savepoint_2
<<< [7] <query> 241 us
>>> [8] <query> SELECT * FROM `differential_hunk` WHERE changesetID = 1
<<< [8] <query> 212 us
>>> [9] <query> DELETE FROM `differential_hunk` WHERE `id` = 1
<<< [9] <query> 216 us
>>> [10] <query> DELETE FROM `differential_changeset` WHERE `id` = 1
<<< [10] <query> 154 us
>>> [11] <query> SAVEPOINT Aphront_Savepoint_2
<<< [11] <query> 118 us
>>> [12] <query> SELECT * FROM `differential_hunk` WHERE changesetID = 2
<<< [12] <query> 194 us
>>> [13] <query> DELETE FROM `differential_hunk` WHERE `id` = 2
<<< [13] <query> 179 us
>>> [14] <query> DELETE FROM `differential_changeset` WHERE `id` = 2
<<< [14] <query> 163 us
>>> [15] <query> SAVEPOINT Aphront_Savepoint_2
<<< [15] <query> 105 us
>>> [16] <query> SELECT * FROM `differential_hunk` WHERE changesetID = 3
<<< [16] <query> 211 us
>>> [17] <query> DELETE FROM `differential_hunk` WHERE `id` = 3
<<< [17] <query> 159 us
>>> [18] <query> DELETE FROM `differential_changeset` WHERE `id` = 3
<<< [18] <query> 152 us
>>> [19] <query> SAVEPOINT Aphront_Savepoint_2
<<< [19] <query> 124 us
>>> [20] <query> SELECT * FROM `differential_hunk` WHERE changesetID = 4
<<< [20] <query> 191 us
>>> [21] <query> DELETE FROM `differential_hunk` WHERE `id` = 4
<<< [21] <query> 155 us
>>> [22] <query> DELETE FROM `differential_changeset` WHERE `id` = 4
<<< [22] <query> 149 us
>>> [23] <query> SELECT * FROM `differential_diffproperty` WHERE diffID = 1
<<< [23] <query> 242 us
>>> [24] <query> DELETE FROM `differential_diffproperty` WHERE `id` = 1
<<< [24] <query> 196 us
>>> [25] <query> DELETE FROM `differential_diff` WHERE `id` = 1
<<< [25] <query> 169 us
>>> [26] <query> DELETE FROM `differential_relationship` WHERE revisionID = 1
<<< [26] <query> 178 us
>>> [27] <query> DELETE FROM `differential_commit` WHERE revisionID = 1
<<< [27] <query> 164 us
>>> [28] <query> SELECT * FROM `differential_comment` WHERE revisionID = 1
<<< [28] <query> 221 us
>>> [29] <query> DELETE FROM `differential_comment` WHERE `id` = 1
<<< [29] <query> 172 us
>>> [30] <query> SELECT * FROM `differential_inlinecomment` WHERE revisionID = 1
<<< [30] <query> 296 us
>>> [31] <query> SELECT * FROM `differential_auxiliaryfield` WHERE revisionPHID = 'PHID-DREV-ooky7ozqukpmwget32oc'
<<< [31] <query> 308 us
>>> [32] <query> SELECT * FROM `differential_affectedpath` WHERE revisionID = 1
<<< [32] <query> 4,173 us
>>> [33] <query> DELETE FROM `differential_revision` WHERE `id` = 1
<<< [33] <query> 231 us
>>> [34] <query> COMMIT
<<< [34] <query> 686 us
OK, destroyed revision.
Reviewers: csilvers, vrana, jungejason
Reviewed By: csilvers
CC: aran
Differential Revision: https://secure.phabricator.com/D2796
2012-06-19 11:52:50 -07:00
vrana
2f85be0243
Add 'description' to Diff dict
2012-06-15 16:16:03 -07:00
vrana
8a9da4b8d0
Add 'creationMethod' to Diff dict
...
Summary: We need it.
Test Plan: Ran 'differential.getdiff', saw it.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D2766
2012-06-15 15:30:19 -07:00
vrana
6cc196a2e5
Move files in Phabricator one level up
...
Summary:
- `kill_init.php` said "Moving 1000 files" - I hope that this is not some limit in `FileFinder`.
- [src/infrastructure/celerity] `git mv utils.php map.php; git mv api/utils.php api.php`
- Comment `phutil_libraries` in `.arcconfig` and run `arc liberate`.
NOTE: `arc diff` timed out so I'm pushing it without review.
Test Plan:
/D1234
Browsed around, especially in `applications/repository/worker/commitchangeparser` and `applications/` in general.
Auditors: epriestley
Maniphest Tasks: T1103
2012-06-01 12:32:44 -07:00
