Bob Trahan 3ef0721ada Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine ... Summary: Fixes T6956. Before this change, we called PhabricatorUser::getOmnipotentUser in the various delete methods to query the data. Now, we use $engine->getViewer(), since its always a good thing to have less calls to PhabricatorUser::getOmnipotentUser thrown around the codebase. I used the "codemod" tool to audit the existing calls to PhabricatorDestructorEngine (all of them) so ostensibly this gets all the spots. If I missed something though, its still going to work, so this change is very low risk. Test Plan: ./bin/remove destroy P1; visit P1 and get a 404 Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6956 Differential Revision: https://secure.phabricator.com/D12866		2015-05-15 14:07:17 -07:00
..
action	Add semi-generic rate limiting infrastructure	2014-04-03 11:22:38 -07:00
application	Implement the getName method in PhabricatorApplication subclasses	2014-07-23 23:52:50 +10:00
controller	Substantially support character encodings and "Highlight As" in changesets	2014-06-20 11:49:41 -07:00
engine	Reduce PhabricatorUser::getOmnipotentUser calls by adding a getViewer method to PhbaricatorDestructionEngine	2015-05-15 14:07:17 -07:00
exception	Add semi-generic rate limiting infrastructure	2014-04-03 11:22:38 -07:00
garbagecollector	Implement bin/remove, for structured destruction of objects	2014-05-01 18:23:31 -07:00
interface	T5409, allow bin/remove to permanently destroy credential and everything associated with it	2014-08-07 16:33:54 -07:00
management	Fix visibility of PhutilArgumentWorkflow::didConstruct methods	2015-01-16 07:42:07 +11:00
storage	Fix visiblity of LiskDAO::getConfiguration()	2015-01-14 06:54:13 +11:00