1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 03:12:41 +01:00
phorge-phorge/src/applications/maniphest
epriestley d321cc810a Freeze "maniphest.gettasktransactions" and make status/priority transactions more consistent
Summary:
Ref T13020. See PHI221.

Freeze legacy method `maniphest.gettasktransactions` in favor of modern method `transaction.search`.

Remove legacy "null on create" behavior from Maniphest status and priority transactions. This behavior is obsolete with EditEngine, and leads to inconsistent transaction sets in the transaction record.

The desired behavior is that transactions which don't do anything (e.g., default value was not changed) don't appear in the transaction log.

Test Plan:
  - Viewed API UI and saw `maniphest.gettasktransactions` marked as "Frozen".
  - Created a new task via web UI (without changing status/priority), queried transactions with `maniphest.gettasktransacitons`/`transaction.search`, no longer saw "null on create" no-op transactions in record.
    - Web UI is unchanged, since these transactions were hidden before and now do not exist.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13020

Differential Revision: https://secure.phabricator.com/D18777
2017-11-22 11:13:53 -08:00
..
__tests__ Use keywords instead of ints to update task priority in ManiphestEditEngine 2017-06-14 14:43:03 -07:00
application Update menu item names for Applications -> Favorites 2017-09-05 19:05:03 -07:00
bulk Use keywords instead of ints to update task priority in ManiphestEditEngine 2017-06-14 14:43:03 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Use keywords instead of ints to update task priority in ManiphestEditEngine 2017-06-14 14:43:03 -07:00
conduit Freeze "maniphest.gettasktransactions" and make status/priority transactions more consistent 2017-11-22 11:13:53 -08:00
config Convert Maniphest custom config to new config types 2017-06-27 12:35:29 -07:00
constants Convert Maniphest custom config to new config types 2017-06-27 12:35:29 -07:00
controller Fix spelling 2017-10-09 10:48:04 -07:00
edge Allow duplicates and merged-in tasks to be queried with edge.search 2017-10-13 13:12:50 -07:00
editor Fix spelling 2017-10-09 10:48:04 -07:00
engineextension New hovercard UI for Maniphest Tasks 2017-04-23 18:58:08 -07:00
export Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
field Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
herald Use keywords instead of ints to update task priority in ManiphestEditEngine 2017-06-14 14:43:03 -07:00
httpparametertype Make "Create Subtask" work properly in EditEngine 2015-12-08 14:29:58 -08:00
lipsum Use keywords instead of ints to update task priority in ManiphestEditEngine 2017-06-14 14:43:03 -07:00
mail Have Maniphest use create transactions when using email 2017-07-25 13:36:50 -07:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
policyrule Allow PolicyRules to serve as "Object Policies" 2015-06-13 15:44:38 -07:00
query Remove "Contains Words" constraint from Maniphest 2017-09-11 18:04:12 -07:00
relationship Update Maniphest for modular transactions 2017-05-15 10:29:06 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
search Reduce the amount of boilerplate that implementing FerretInterface requires 2017-09-07 13:23:31 -07:00
storage Reduce the amount of boilerplate that implementing FerretInterface requires 2017-09-07 13:23:31 -07:00
typeahead Provide UI hints about task subtypes 2017-05-26 13:58:41 -07:00
view Separate button CSS classes 2017-06-05 20:14:34 +00:00
xaction Freeze "maniphest.gettasktransactions" and make status/priority transactions more consistent 2017-11-22 11:13:53 -08:00