1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 15:00:58 +01:00
phorge-phorge/webroot/rsrc/js/application
epriestley 2a355d8548 Make Diffusion "Last Modified" rendering less fragile
Summary:
Ref T9524. Because fetching the last time files were modified in Diffusion can be slow, we bring it in over Ajax.

The logic to fetch and paint the table is kind of fragile because there are two different definitions of the columns right now and we break in a bad way if they differ.

In particular, calling `diffusion.updatecoverage` can populate a "lint commit" for a repository, which tries to generate lint information in one of the views (but not the other one).

In the longer run I think we're removing some of the concepts here and this rendering should be rebuilt to not have two separate column definitions, but just make it degrade gracefully for now since those are larger changes.

Test Plan:
Reproduced the issue in T9524 by calling `diffusion.updatecoverage` on a repostiory. Specifically, this has a side effect of creating a "lint commit" which triggers a "lint" column in this table, sort of.

Applied this patch, got a clean render.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9524

Differential Revision: https://secure.phabricator.com/D14243
2015-10-07 07:32:27 -07:00
..
aphlict Merge branch 'master' into redesign-2015 2015-06-22 15:52:40 -07:00
auth Add Persona auth provider 2013-10-14 14:34:57 -07:00
calendar Show informative errors when attempting to set a recurrence end date on a non-recurring event. 2015-06-07 15:57:19 -07:00
config Fix custom field selector control in cases where the user doesn't edit anything 2015-05-25 05:34:23 -07:00
conpherence Remove Files Widget from Conpherence 2015-08-20 08:24:42 -07:00
countdown Define JavaScript functions before they are used 2014-12-30 02:53:32 -08:00
daemon Execute Maniphest batch edits in the background with a web UI progress bar 2015-06-23 13:36:16 -07:00
dashboard Fix various spelling mistakes 2014-07-13 00:45:33 +10:00
differential Show users what's wrong when they try to edit an inline with an editor already open 2015-09-10 11:36:38 -07:00
diffusion Make Diffusion "Last Modified" rendering less fragile 2015-10-07 07:32:27 -07:00
doorkeeper Various linter fixes. 2014-02-26 12:44:58 -08:00
files Various linter fixes. 2014-02-26 12:44:58 -08:00
herald Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
maniphest [Redesign] Fix Maniphest subpriority editing 2015-06-30 09:37:12 -07:00
owners Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
passphrase Rename Passphrase credential control JS 2015-03-02 13:01:00 -08:00
phame Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
pholio Quicksand and Pholio - make mock edit work 2015-05-07 10:42:07 -07:00
phortune Remove support for Balanced payments 2015-03-13 15:47:37 -07:00
policy Allow different policy rules for different types of objects 2015-06-13 15:44:03 -07:00
projects Conpherence + workboards - fix dragging behavior breaking on subsequent page loads 2015-05-12 11:37:55 -07:00
releeph Make scrolling happen relative to the main content frame 2015-01-25 08:42:40 -08:00
repository Symbol Search: Allow ctrl-click with no hover 2015-08-27 04:17:38 -07:00
search Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
slowvote Replace the primary scrollbar with a fake one to prepare for a persistent chat column 2015-01-23 13:29:15 -08:00
transactions Don't put a spacer line on the bottom of previews 2015-05-18 12:18:10 -07:00
typeahead Implement viewer() and members(project) typeahead functions 2015-04-17 11:06:58 -07:00
uiexample Use window.confirm instead of confirm 2014-12-30 02:55:12 -08:00