1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/config
epriestley b62ecb7c11 Make UX for misspelled or delted config much less bad
Summary:
Fixes T3436. Currently, when installs have configuration options which we don't know about, we raise a fairly confusing/ambiguous message about the options being unknown. Instead:

  - Keep a list of previously valid (but now deleted) config, with explanatory reasons for what happened to it. Present this information, along with altenate wording ("Obsolete Config" instead of "Unknown Config") where applicable.
  - Show a list of all the places the config is defined.
  - Provide an active link to delete it from the web UI.
  - Provide a command to delete it from the CLI.
  - Allow `bin/config delete` to delete configuration options which no longer have a definition.

Test Plan:
  - Set an auth key in database, local and file config.
  - Walked through the setup issue, cleaning it up.
  - Set an invalid key and made sure I still got a reasonable error (this now has better cleanup instructions).

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T3436

Differential Revision: https://secure.phabricator.com/D6317
2013-06-26 11:01:19 -07:00
..
application Button to ignore setup issues + refractoring 2013-03-06 14:14:10 -08:00
check Make UX for misspelled or delted config much less bad 2013-06-26 11:01:19 -07:00
controller Make UX for misspelled or delted config much less bad 2013-06-26 11:01:19 -07:00
custom Allow configuration to have custom UI types 2013-06-07 12:36:18 -07:00
editor Use setContentSourceFromRequest() in more places 2013-05-24 10:48:34 -07:00
exception Allow configuration to be explicitly validated, including validation of complex attributes 2013-01-01 18:15:03 -08:00
issue Fixed T2630 2013-04-10 13:11:22 -07:00
json Mask remaining config values, and implement set type 2013-01-16 15:06:07 -08:00
management Make UX for misspelled or delted config much less bad 2013-06-26 11:01:19 -07:00
option Add "invisible" styling/config to Phabricator 2013-06-25 08:40:29 -07:00
query Use transactions to show edit history for Configuration 2013-01-01 18:14:41 -08:00
response [SECURITY] Prevented PhabricatorSetupIssueView from exposing sensitive config options. 2013-04-06 00:39:53 -07:00
storage Button to ignore setup issues + refractoring 2013-03-06 14:14:10 -08:00
view Make UX for misspelled or delted config much less bad 2013-06-26 11:01:19 -07:00