1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
phorge-phorge/src/applications/config/check
epriestley b62ecb7c11 Make UX for misspelled or delted config much less bad
Summary:
Fixes T3436. Currently, when installs have configuration options which we don't know about, we raise a fairly confusing/ambiguous message about the options being unknown. Instead:

  - Keep a list of previously valid (but now deleted) config, with explanatory reasons for what happened to it. Present this information, along with altenate wording ("Obsolete Config" instead of "Unknown Config") where applicable.
  - Show a list of all the places the config is defined.
  - Provide an active link to delete it from the web UI.
  - Provide a command to delete it from the CLI.
  - Allow `bin/config delete` to delete configuration options which no longer have a definition.

Test Plan:
  - Set an auth key in database, local and file config.
  - Walked through the setup issue, cleaning it up.
  - Set an invalid key and made sure I still got a reasonable error (this now has better cleanup instructions).

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T3436

Differential Revision: https://secure.phabricator.com/D6317
2013-06-26 11:01:19 -07:00
..
PhabricatorSetupCheck.php Config option to ignore setup issues 2013-02-22 10:08:20 -08:00
PhabricatorSetupCheckAPC.php Detect and raise setup warnings from within Phabricator 2012-12-30 06:37:49 -08:00
PhabricatorSetupCheckAuth.php Add first-time-setup registration flow 2013-06-19 16:28:48 -07:00
PhabricatorSetupCheckBaseURI.php Consolidate HTTP header access 2013-02-09 15:01:57 -08:00
PhabricatorSetupCheckBinaries.php Detect missing 'svn', 'hg' and 'git' during setup 2013-05-27 13:40:34 -07:00
PhabricatorSetupCheckDatabase.php Fixed T2630 2013-04-10 13:11:22 -07:00
PhabricatorSetupCheckExtensions.php Require mysql or mysqli, not both 2013-03-03 11:37:53 -08:00
PhabricatorSetupCheckExtraConfig.php Make UX for misspelled or delted config much less bad 2013-06-26 11:01:19 -07:00
PhabricatorSetupCheckFileinfo.php Add a setup warning about missing 'fileinfo' 2013-05-17 10:00:40 -07:00
PhabricatorSetupCheckGD.php Migrate max_allowed_packet and GD checks to new setup stuff 2013-01-19 08:41:45 -08:00
PhabricatorSetupCheckImagemagick.php Add setup checks for the availability of 'which' and 'diff' binaries 2013-05-23 14:42:07 -07:00
PhabricatorSetupCheckInvalidConfig.php Repair invalid configuration by setting values back to defaults 2013-01-17 16:25:38 -08:00
PhabricatorSetupCheckMail.php Fixed T2630 2013-04-10 13:11:22 -07:00
PhabricatorSetupCheckMySQL.php Fixed T2630 2013-04-10 13:11:22 -07:00
PhabricatorSetupCheckPath.php Move PATH checks to post-install 2013-01-22 14:45:19 -08:00
PhabricatorSetupCheckPHPConfig.php Move open_basedir and safe_mode checks into new setup 2013-01-22 16:15:54 -08:00
PhabricatorSetupCheckPygment.php Fixed T2630 2013-04-10 13:11:22 -07:00
PhabricatorSetupCheckStorage.php Add a setup issue to warn about an unconfigured upload limit 2013-06-12 05:49:41 -07:00
PhabricatorSetupCheckTimezone.php Make timezone configuration impossible to get wrong 2013-01-19 08:38:37 -08:00