mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-11 17:32:41 +01:00
5d8ddd888c
Summary: We no longer need to do PHP CLI checks (D4568) or run `git submodule` (D4581) so we don't need $PATH to be set to complete setup. Move it to post-install. Drop the instructions about PHP-FPM because the Phabricator config is dramatically easier now that we have it. Test Plan: Set environment.append-paths to various things, faked lack of $PATH, verified I got the warning when I expected to setting Phabricator config cleared it. Reviewers: codeblock, btrahan Reviewed By: codeblock CC: aran Maniphest Tasks: T2228 Differential Revision: https://secure.phabricator.com/D4585
30 lines
1,023 B
PHP
30 lines
1,023 B
PHP
<?php
|
|
|
|
final class PhabricatorSetupCheckPath extends PhabricatorSetupCheck {
|
|
|
|
protected function executeChecks() {
|
|
// NOTE: We've already appended `environment.append-paths`, so we don't
|
|
// need to explicitly check for it.
|
|
$path = getenv('PATH');
|
|
|
|
if (!$path) {
|
|
$summary = pht(
|
|
'The environmental variable $PATH is empty. Phabricator will not '.
|
|
'be able to execute some commands.');
|
|
|
|
$message = pht(
|
|
'The environmental variable $PATH is empty. Phabricator needs to '.
|
|
'execute some system commands, like `svn`, `git`, `hg`, and `diff`. '.
|
|
'To execute these commands, the binaries must be available in the '.
|
|
'webserver\'s $PATH. You can set additional paths in Phabricator '.
|
|
'configuration.');
|
|
|
|
$this
|
|
->newIssue('config.environment.append-paths')
|
|
->setName(pht('$PATH Not Set'))
|
|
->setSummary($summary)
|
|
->setMessage($message)
|
|
->addPhabricatorConfig('environment.append-paths');
|
|
}
|
|
}
|
|
}
|