revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-07 12:28:28 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
Andre Klapper 05798a6301 Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without parameter 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementGenerateKeyWorkflow.php:23]
```

Test Plan: Run `../phorge/bin/files generate-key`: Get no `strlen()` error anymore but only expected output `Usage Exception: Specify the type of key to generate with --type.`

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25579
2024-04-17 00:29:24 +02:00
..
almanac Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
aphlict Aphlict - search for default config in the right place 2023-07-24 00:42:06 -07:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Allow to uninstall (hide) Audit application 2024-02-12 12:10:06 +01:00
auth Fix config transaction rendering error on auth page by allowing PhutilSafeHTML 2024-02-12 11:52:29 +01:00
badges Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
base Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
cache Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock" pathways 2022-05-03 15:57:15 -07:00
calendar Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
celerity Improve remarkup codeblock syntax highlighting when using Dark Mode 2024-03-03 15:58:03 +01:00
conduit Make sure offset is an integer 2024-04-12 19:28:16 +03:00
config Fix setup check for gzip request mangling being sent as GET 2024-04-02 21:49:00 +03:00
conpherence Improve messages when no image formats are supported (due to GD not installed) 2024-02-13 17:06:57 +01:00
console log deprecation events in Dark Console 2023-08-31 08:18:28 -07:00
countdown Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
daemon Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
dashboard Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
differential Use predictable filenames when downloading raw diffs from a revision 2024-03-07 00:03:27 +08:00
diffusion Make sure offset is an integer 2024-04-12 19:28:16 +03:00
diviner Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
doorkeeper Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
draft/storage Save drafts for inline comments currently being edited 2020-05-04 13:19:42 -07:00
drydock Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
fact Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
favorites Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
feed Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
files Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without parameter 2024-04-17 00:29:24 +02:00
flag Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
fund Deprecate Fund and Phortune prototype applications 2024-02-06 09:16:19 +01:00
guides Remove product literal strings in "pht()", part 5 2022-04-25 12:22:27 -07:00
harbormaster Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
help Tokenize external editor links so they can be safely materialized on the client 2020-04-19 09:02:49 -07:00
herald Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
home Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page 2023-05-01 15:37:56 +02:00
legalpad Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
maniphest Show rest of task page when graph errors out 2024-04-05 13:26:38 +03:00
meta Fix important regression in search engine 2024-03-26 07:30:10 +01:00
metamta Fix PHP 8.1 "strlen(null)" exception when received email lacks From header 2024-03-31 15:21:11 +02:00
multimeter Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page 2023-05-29 12:35:54 +02:00
notification Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
nuance Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
oauthserver Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
owners Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
packages Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
passphrase Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
paste Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
people Improve messages when no image formats are supported (due to GD not installed) 2024-02-13 17:06:57 +01:00
phame Improve messages when no image formats are supported (due to GD not installed) 2024-02-13 17:06:57 +01:00
phid Correct docs of PhabricatorPHIDType::getAllTypesForApplication() 2024-04-08 13:14:01 +02:00
phlux Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
pholio Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
phortune Improve messages when no image formats are supported (due to GD not installed) 2024-02-13 17:06:57 +01:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phrequent Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
phriction Fix an instance of strlen(null) 2024-02-23 17:06:26 +02:00
phurl Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
policy Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
ponder Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
project Fix PHP 8.1 "strlen(null)" exception querying project tags for autocomplete without additional hashtag slugs defined 2024-04-01 10:40:34 +02:00
remarkup Generate file attachment transactions for explicit Remarkup attachments on common edit pathways 2022-05-19 13:21:04 -07:00
repository fix PHP 8 "strlen(null)" when moving paths with missing options 2024-02-12 11:05:31 +01:00
search Replace all phurl.io short URIs with target URIs 2024-02-28 14:59:29 +01:00
settings Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
slowvote Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
spaces Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
subscriptions Remove product literal strings in "pht()", part 24 2022-04-25 16:46:26 -07:00
support/application
system Show Deprecation Warnings as Setup Warnings 2023-12-08 17:55:18 +02:00
tokens Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
transactions Comments: avoid confusing warning about "core:file" 2024-02-29 09:17:09 +01:00
typeahead Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
uiexample Implements copy button in clone repo modal 2024-02-15 19:38:39 +01:00
xhprof Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00