Andre Klapper 25aebab655 Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string ... Summary: `::class` is available since PHP 5.5 (5.5 is a minimal requirement by Phorge): https://www.php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class It makes finding code using IDEs easier; see discussion in D25500. Thus replace all string return values with returning the `::class` constant instead, with one exception: 'PhabricatorSettingApplication' in `PhabricatorUserPreferencesSearchEngine.php` does not exist and makes arc lint fail so this string remained unchanged. Also note that two occurrences were wrapped in `pht()` for reasons I do not know. List of functions whose return value get updated in this code change: * getApplicationClassName() * getAdapterApplicationClass() * getDatasourceApplicationClass() * getEditorApplicationClass() * getEngineApplicationClass() * getPHIDTypeApplicationClass() * getQueryApplicationClass() cf. T15158 Test Plan: Too broad - click around, basically. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15158 Differential Revision: https://we.phorge.it/D25524		2024-02-05 14:11:36 +01:00
..
application
atom	Fix PHP 8.1 trim(null) exception in ./bin/diviner generate	2023-08-11 10:37:31 +01:00
atomizer	Fix a constant typo in Diviner ("DECLARATAION" -> "TION")	2017-03-04 09:54:10 -08:00
cache
capability
controller	Fix Diviner strlen(null) error when clicking on a link	2023-09-06 12:23:42 +01:00
editor	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
markup	Replace "URI->setQueryParams()" after initialization with a constructor argument	2019-02-14 11:46:37 -08:00
phid	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
publisher	Update PhabricatorLiskDAO::chunkSQL() for new %Q semantics	2018-11-13 08:59:18 -08:00
query	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
renderer	Fix errors found by PHPStan	2017-02-17 10:10:15 +00:00
search	Fix flipped open/closed status for Diviner atoms in search index	2017-02-13 13:12:32 -08:00
storage	PHP 8 and Diviner Technical Documentation	2023-08-18 15:38:16 -07:00
typeahead	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
view
workflow	Generate Diviner book for Javelin	2023-08-30 11:20:12 -07:00