1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-12 12:24:50 +01:00
phorge-phorge/src/applications/dashboard/install
Andre Klapper ab69bcccd9 Fix PHP 8.1 "strlen(null)" exceptions which block adding Dashboard to Project Menu
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15339

Test Plan: Applied these four changes and `/dashboard/install/1/project/` finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15339

Differential Revision: https://we.phorge.it/D25184
2023-05-06 04:04:20 +02:00
..
PhabricatorDashboardApplicationInstallWorkflow.php Make the "Install Dashboard" flow smoother 2019-04-09 13:34:09 -07:00
PhabricatorDashboardFavoritesInstallWorkflow.php Make the "Install Dashboard" flow smoother 2019-04-09 13:34:09 -07:00
PhabricatorDashboardHomeInstallWorkflow.php Make the "Install Dashboard" flow smoother 2019-04-09 13:34:09 -07:00
PhabricatorDashboardInstallWorkflow.php Make the "Install Dashboard" flow smoother 2019-04-09 13:34:09 -07:00
PhabricatorDashboardObjectInstallWorkflow.php Fix PHP 8.1 "strlen(null)" exceptions which block adding Dashboard to Project Menu 2023-05-06 04:04:20 +02:00
PhabricatorDashboardPortalInstallWorkflow.php Make the "Install Dashboard" flow smoother 2019-04-09 13:34:09 -07:00
PhabricatorDashboardProjectInstallWorkflow.php Make the "Install Dashboard" flow smoother 2019-04-09 13:34:09 -07:00