1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 08:20:57 +01:00
phorge-phorge/src/applications/drydock/controller
epriestley 2ef5b5321d Move Drydock logs to PHIDs and increased structure
Summary:
Ref T9252. Several general changes here:

  - Moves logs to use PHIDs instead of IDs. This generally improves flexibility (for example, it's a lot easier to render handles).
  - Adds `blueprintPHID` to logs. Although you can usually figure this out from the leasePHID or resourcePHID, it lets us query relevant logs on Blueprint views.
  - Instead of making logs a top-level object, make them strictly a sub-object of Blueprints, Resources and Leases. So you go Drydock > Lease > Logs, etc., to get to logs.
    - I might restore the "everything" view eventually, but it doesn't interact well with policies and I'm not sure it's very useful. A policy-violating `bin/drydock log` might be cleaner.
  - Policy-wise, we always show you that logs exist, we just don't show you log content if it's about something you can't see. This is similar to seeing restricted handles in other applications.
  - Instead of just having a message, give logs "type" + "data". This will let logs be more structured and translatable. This is similar to recent changes to Herald which seem to have worked well.

Test Plan:
Added some placeholder log writes, viewed those logs in the UI.

{F855199}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9252

Differential Revision: https://secure.phabricator.com/D14196
2015-10-01 08:06:23 -07:00
..
DrydockBlueprintController.php Fix method visibility for PhabricatorController subclasses 2015-01-07 07:34:59 +11:00
DrydockBlueprintCreateController.php Update Drydock for handleRequest 2015-07-27 07:56:52 -07:00
DrydockBlueprintDisableController.php Allow Drydock blueprints to be disabled 2015-09-24 10:18:17 -07:00
DrydockBlueprintEditController.php Allow Drydock blueprints to be disabled 2015-09-24 10:18:17 -07:00
DrydockBlueprintListController.php Update Drydock for handleRequest 2015-07-27 07:56:52 -07:00
DrydockBlueprintViewController.php Move Drydock logs to PHIDs and increased structure 2015-10-01 08:06:23 -07:00
DrydockConsoleController.php Give Drydock resources a proper expiry mechanism 2015-09-28 09:35:14 -07:00
DrydockController.php Move Drydock logs to PHIDs and increased structure 2015-10-01 08:06:23 -07:00
DrydockLeaseController.php Show recent active leases on Drydock resource detail 2015-09-24 15:28:59 -07:00
DrydockLeaseListController.php Show recent active leases on Drydock resource detail 2015-09-24 15:28:59 -07:00
DrydockLeaseReleaseController.php Add a command queue to Drydock to manage lease/resource release 2015-09-23 07:42:08 -07:00
DrydockLeaseViewController.php Move Drydock logs to PHIDs and increased structure 2015-10-01 08:06:23 -07:00
DrydockLogController.php Move Drydock logs to PHIDs and increased structure 2015-10-01 08:06:23 -07:00
DrydockLogListController.php Move Drydock logs to PHIDs and increased structure 2015-10-01 08:06:23 -07:00
DrydockResourceController.php Show recent active leases on Drydock resource detail 2015-09-24 15:28:59 -07:00
DrydockResourceListController.php Show recent active resources on Drydock blueprint detail, with link to all 2015-09-24 13:52:43 -07:00
DrydockResourceReleaseController.php Add a command queue to Drydock to manage lease/resource release 2015-09-23 07:42:08 -07:00
DrydockResourceViewController.php Move Drydock logs to PHIDs and increased structure 2015-10-01 08:06:23 -07:00