mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-24 15:52:41 +01:00
2ef5b5321d
Summary: Ref T9252. Several general changes here: - Moves logs to use PHIDs instead of IDs. This generally improves flexibility (for example, it's a lot easier to render handles). - Adds `blueprintPHID` to logs. Although you can usually figure this out from the leasePHID or resourcePHID, it lets us query relevant logs on Blueprint views. - Instead of making logs a top-level object, make them strictly a sub-object of Blueprints, Resources and Leases. So you go Drydock > Lease > Logs, etc., to get to logs. - I might restore the "everything" view eventually, but it doesn't interact well with policies and I'm not sure it's very useful. A policy-violating `bin/drydock log` might be cleaner. - Policy-wise, we always show you that logs exist, we just don't show you log content if it's about something you can't see. This is similar to seeing restricted handles in other applications. - Instead of just having a message, give logs "type" + "data". This will let logs be more structured and translatable. This is similar to recent changes to Herald which seem to have worked well. Test Plan: Added some placeholder log writes, viewed those logs in the UI. {F855199} Reviewers: chad Reviewed By: chad Maniphest Tasks: T9252 Differential Revision: https://secure.phabricator.com/D14196
147 lines
3.9 KiB
PHP
147 lines
3.9 KiB
PHP
<?php
|
|
|
|
final class DrydockLeaseViewController extends DrydockLeaseController {
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
$viewer = $request->getViewer();
|
|
$id = $request->getURIData('id');
|
|
|
|
$lease = id(new DrydockLeaseQuery())
|
|
->setViewer($viewer)
|
|
->withIDs(array($id))
|
|
->needUnconsumedCommands(true)
|
|
->executeOne();
|
|
if (!$lease) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$id = $lease->getID();
|
|
$lease_uri = $this->getApplicationURI("lease/{$id}/");
|
|
|
|
$title = pht('Lease %d', $lease->getID());
|
|
|
|
$header = id(new PHUIHeaderView())
|
|
->setHeader($title);
|
|
|
|
if ($lease->isReleasing()) {
|
|
$header->setStatus('fa-exclamation-triangle', 'red', pht('Releasing'));
|
|
}
|
|
|
|
$actions = $this->buildActionListView($lease);
|
|
$properties = $this->buildPropertyListView($lease, $actions);
|
|
|
|
$log_query = id(new DrydockLogQuery())
|
|
->withLeasePHIDs(array($lease->getPHID()));
|
|
|
|
$log_box = $this->buildLogBox(
|
|
$log_query,
|
|
$this->getApplicationURI("lease/{$id}/logs/query/all/"));
|
|
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
$crumbs->addTextCrumb($title, $lease_uri);
|
|
|
|
$locks = $this->buildLocksTab($lease->getPHID());
|
|
$commands = $this->buildCommandsTab($lease->getPHID());
|
|
|
|
$object_box = id(new PHUIObjectBoxView())
|
|
->setHeader($header)
|
|
->addPropertyList($properties, pht('Properties'))
|
|
->addPropertyList($locks, pht('Slot Locks'))
|
|
->addPropertyList($commands, pht('Commands'));
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$crumbs,
|
|
$object_box,
|
|
$log_box,
|
|
),
|
|
array(
|
|
'title' => $title,
|
|
));
|
|
|
|
}
|
|
|
|
private function buildActionListView(DrydockLease $lease) {
|
|
$viewer = $this->getViewer();
|
|
|
|
$view = id(new PhabricatorActionListView())
|
|
->setUser($viewer)
|
|
->setObjectURI($this->getRequest()->getRequestURI())
|
|
->setObject($lease);
|
|
|
|
$id = $lease->getID();
|
|
|
|
$can_release = $lease->canRelease();
|
|
if ($lease->isReleasing()) {
|
|
$can_release = false;
|
|
}
|
|
|
|
$can_edit = PhabricatorPolicyFilter::hasCapability(
|
|
$viewer,
|
|
$lease,
|
|
PhabricatorPolicyCapability::CAN_EDIT);
|
|
|
|
$view->addAction(
|
|
id(new PhabricatorActionView())
|
|
->setName(pht('Release Lease'))
|
|
->setIcon('fa-times')
|
|
->setHref($this->getApplicationURI("/lease/{$id}/release/"))
|
|
->setWorkflow(true)
|
|
->setDisabled(!$can_release || !$can_edit));
|
|
|
|
return $view;
|
|
}
|
|
|
|
private function buildPropertyListView(
|
|
DrydockLease $lease,
|
|
PhabricatorActionListView $actions) {
|
|
$viewer = $this->getViewer();
|
|
|
|
$view = new PHUIPropertyListView();
|
|
$view->setActionList($actions);
|
|
|
|
$view->addProperty(
|
|
pht('Status'),
|
|
DrydockLeaseStatus::getNameForStatus($lease->getStatus()));
|
|
|
|
$view->addProperty(
|
|
pht('Resource Type'),
|
|
$lease->getResourceType());
|
|
|
|
$owner_phid = $lease->getOwnerPHID();
|
|
if ($owner_phid) {
|
|
$owner_display = $viewer->renderHandle($owner_phid);
|
|
} else {
|
|
$owner_display = phutil_tag('em', array(), pht('No Owner'));
|
|
}
|
|
$view->addProperty(pht('Owner'), $owner_display);
|
|
|
|
$resource_phid = $lease->getResourcePHID();
|
|
if ($resource_phid) {
|
|
$resource_display = $viewer->renderHandle($resource_phid);
|
|
} else {
|
|
$resource_display = phutil_tag('em', array(), pht('No Resource'));
|
|
}
|
|
$view->addProperty(pht('Resource'), $resource_display);
|
|
|
|
$until = $lease->getUntil();
|
|
if ($until) {
|
|
$until_display = phabricator_datetime($until, $viewer);
|
|
} else {
|
|
$until_display = phutil_tag('em', array(), pht('Never'));
|
|
}
|
|
$view->addProperty(pht('Expires'), $until_display);
|
|
|
|
$attributes = $lease->getAttributes();
|
|
if ($attributes) {
|
|
$view->addSectionHeader(
|
|
pht('Attributes'), 'fa-list-ul');
|
|
foreach ($attributes as $key => $value) {
|
|
$view->addProperty($key, $value);
|
|
}
|
|
}
|
|
|
|
return $view;
|
|
}
|
|
|
|
}
|