mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-13 10:22:42 +01:00
07b60b2016
Summary: It is now possible to set config setting requiring class of certain implementation to something completely else. The consequence is that your Phabricator may stop working after update because you didn't implement some new method. This diff validates the class upon usage. It throws exception which is better than fatal thrown currently after calling undefined method. Better solution would be to validate classes when setting the config but it would be too expensive - respective class definitions would have to be loaded and checked by reflection. I was also thinking about some check script but nobody would run it after changing config. The same behavior should be implemented for these settings: - metamta.mail-adapter - metamta.maniphest.reply-handler - metamta.differential.reply-handler - metamta.diffusion.reply-handler - storage.engine-selector - search.engine-selector - differential.field-selector - maniphest.custom-task-extensions-class - aphront.default-application-configuration-class - controller.oauth-registration Test Plan: Send comment, verify that it pass. Change `metamta.differential.reply-handler` to incompatible class, verify that sending comment shows nice red exception. Set `metamta.differential.reply-handler` to empty string, verify that it throws. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1919 |
||
|---|---|---|
| .. | ||
| base | ||
| ccwelcome | ||
| comment | ||
| diffcontent | ||
| exception | ||
| newdiff | ||
| reviewrequest | ||