1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00
phorge-phorge/src/applications/pholio
epriestley 0a069cb55a Require a viewer to load handles
Summary:
Unmuck almost all of the we-sort-of-have-viewers-some-of-the-time mess.

There are a few notable cases here:

  - I used Omnipotent users when indexing objects for search. I think this is correct; we do policy filtering when showing results.
  - I cheated in a bad way in the Remarkup object rule, but fixing this requires fixing all the PhabricatorRemarkupEngine callsites (there are 85). I'll do that in the next diff.
  - I cheated in a few random places, like when sending mail about package edits. These aren't a big deal.

Test Plan:
  - Grepped for all PhabricatorObjectHandleData references.
  - Gave them viewers.

Reviewers: vrana

Reviewed By: vrana

CC: aran, edward

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D5151
2013-02-28 17:15:09 -08:00
..
application Prepare for hovercards 2013-02-26 14:59:31 -08:00
config MetaMTA: Owners, Pholio, Macro 2013-01-16 10:52:30 -08:00
constants Drafts are saved as inline comments for images when user comments mock 2013-02-07 08:02:52 -08:00
controller Require a viewer to load handles 2013-02-28 17:15:09 -08:00
editor Pholio inline comments appear after comment 2013-02-25 06:19:10 -08:00
mail Remove some more copyright headers that survived in branches, etc., through the great header purge. See D3886. 2012-12-05 09:27:27 -08:00
query Moved rendering to PholioInlineCommentView 2013-02-19 14:14:40 -08:00
remarkup Prepare for hovercards 2013-02-26 14:59:31 -08:00
search Support search indexing in ApplicationTransaction 2012-12-21 14:21:50 -08:00
storage Dark description tweaks for Pholio. 2013-02-27 20:10:30 -08:00
view Various highlights 2013-02-27 10:45:51 -08:00