revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 01:12:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 0a069cb55a Require a viewer to load handles 
Summary:
Unmuck almost all of the we-sort-of-have-viewers-some-of-the-time mess.

There are a few notable cases here:

  - I used Omnipotent users when indexing objects for search. I think this is correct; we do policy filtering when showing results.
  - I cheated in a bad way in the Remarkup object rule, but fixing this requires fixing all the PhabricatorRemarkupEngine callsites (there are 85). I'll do that in the next diff.
  - I cheated in a few random places, like when sending mail about package edits. These aren't a big deal.

Test Plan:
  - Grepped for all PhabricatorObjectHandleData references.
  - Gave them viewers.

Reviewers: vrana

Reviewed By: vrana

CC: aran, edward

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D5151
2013-02-28 17:15:09 -08:00
..
arcanist/conduit Move Conduit methods inside applications 2012-12-21 12:21:59 -08:00
audit Require a viewer to load handles 2013-02-28 17:15:09 -08:00
auth Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
base Prepare for hovercards 2013-02-26 14:59:31 -08:00
cache Use direct inclusion, not submodules, to bring Javelin into Phabricator 2013-01-22 12:43:55 -08:00
calendar Calendar minor pht. 2013-02-23 07:12:36 -08:00
chatlog Chatlog pht 2013-02-23 07:12:53 -08:00
conduit Merge branch 'master' into phutil_tag 2013-02-13 12:42:57 -08:00
config Check for pygmentize, not pgymentize 2013-02-28 10:46:04 -08:00
conpherence Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
countdown Pre-prepare for hovercards 2013-02-26 14:57:41 -08:00
daemon pht for Daemons. 2013-02-26 19:51:36 -08:00
differential Require a viewer to load handles 2013-02-28 17:15:09 -08:00
diffusion Require a viewer to load handles 2013-02-28 17:15:09 -08:00
directory/controller Require a viewer to load handles 2013-02-28 17:15:09 -08:00
diviner Avoid double escaping in Remarkup 2013-02-21 16:26:26 -08:00
draft/storage Add draft support to ApplicationTransactions 2012-12-21 05:57:14 -08:00
drydock Convert AphrontTableView to safe HTML 2013-02-09 15:11:38 -08:00
fact Convert AphrontTableView to safe HTML 2013-02-09 15:11:38 -08:00
feed Fixes T2523 - Comments are being displayed in feed. 2013-02-26 08:59:26 -08:00
files Add ImageView to PropertyListView 2013-02-26 16:37:45 -08:00
flag Require a viewer to load handles 2013-02-28 17:15:09 -08:00
harbormaster Add HarbormasterRunnerWorker, for running CI tests 2012-12-17 13:43:26 -08:00
help/controller Replace array_interleave() by phutil_implode_html() 2013-02-11 15:27:43 -08:00
herald Require a viewer to load handles 2013-02-28 17:15:09 -08:00
macro Add ImageView to PropertyListView 2013-02-26 16:37:45 -08:00
mailinglists Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
maniphest Require a viewer to load handles 2013-02-28 17:15:09 -08:00
meta Stylize bubble counts. 2013-02-22 15:46:29 -08:00
metamta Require a viewer to load handles 2013-02-28 17:15:09 -08:00
notification Convert everything to safe HTML 2013-02-13 12:35:40 -08:00
oauthserver Fix an OAuthServer issue where an attacker could make a link function over HTTP when it should be HTTPS-only 2013-02-19 16:09:36 -08:00
owners Require a viewer to load handles 2013-02-28 17:15:09 -08:00
paste Missing change from D5120 which I incorrectly discarded in a merge. 2013-02-27 07:19:57 -08:00
people Add user omnipotence 2013-02-28 11:01:40 -08:00
phame Require a viewer to load handles 2013-02-28 17:15:09 -08:00
phid Require a viewer to load handles 2013-02-28 17:15:09 -08:00
pholio Require a viewer to load handles 2013-02-28 17:15:09 -08:00
phortune Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
phpast Convert everything to safe HTML 2013-02-13 12:35:40 -08:00
phriction changed wordwrap call to utf8 hard wrap call in multiple places 2013-02-28 09:17:58 -08:00
policy Add user omnipotence 2013-02-28 11:01:40 -08:00
ponder Require a viewer to load handles 2013-02-28 17:15:09 -08:00
project Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
remarkup/conduit Convert Remarkup to safe HTML 2013-02-13 12:34:49 -08:00
repository Require a viewer to load handles 2013-02-28 17:15:09 -08:00
search Require a viewer to load handles 2013-02-28 17:15:09 -08:00
settings Don't show the DarkConsole preference if is false in the config 2013-02-22 06:16:48 -08:00
slowvote Require a viewer to load handles 2013-02-28 17:15:09 -08:00
status Delete license headers from files 2012-11-05 11:16:51 -08:00
subscriptions Integrate subscriptions with ApplicationTransactions 2013-02-17 06:37:09 -08:00
tokens Require a viewer to load handles 2013-02-28 17:15:09 -08:00
transactions changed wordwrap call to utf8 hard wrap call in multiple places 2013-02-28 09:17:58 -08:00
typeahead Convert AphrontTableView to safe HTML 2013-02-09 15:11:38 -08:00
uiexample Convert everything to safe HTML 2013-02-13 12:35:40 -08:00
xhprof Require a viewer to load handles 2013-02-28 17:15:09 -08:00