1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/differential
epriestley 119c2b8cec Fix differential.getdiff, etc., for diffs with no Arcanist Project
Summary:
`getArcanistProjectName()` has some logic which gets messy with the `self::ATTACHABLE` mechanism. This makes `differential.getdiff` and similar Conduit methods throw an exception when querying a diff which doesn't have a project. See <http://pastebin.com/Czzrd0Jz>.

Instead, unconditionally attach a project (possibly `null`) when loading diffs if they need projects.

Test Plan: Ran `differential.getdiff` against a `arc diff --raw` diff with no project, got a result instead of an exception.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, sttwister

Differential Revision: https://secure.phabricator.com/D7101
2013-09-24 10:48:40 -07:00
..
__tests__ Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
application Partially generalize Remarkup previews and add support to Differential 2013-08-05 10:46:39 -07:00
conduit Fix a missing setViewer() in differential.getrevision 2013-09-23 15:22:57 -07:00
config Add a "list<regex>" config option and move regex config to it 2013-09-13 11:48:00 -07:00
constants ObjectHeader Status icons 2013-09-24 08:42:04 -07:00
controller Minor fix to minor fix to diff order 2013-09-18 11:56:48 -07:00
doorkeeper Improve voicing in text published to JIRA issues 2013-09-10 15:22:24 -07:00
editor Dispatch Differential edit events from Editor, not Controller 2013-09-16 08:04:14 -07:00
events ObjectHeader Status icons 2013-09-24 08:42:04 -07:00
exception Delete license headers from files 2012-11-05 11:16:51 -08:00
field ObjectHeader Status icons 2013-09-24 08:42:04 -07:00
lipsum xDiffs and Revisions Generating 2013-05-06 14:11:37 -07:00
mail Add a differential.getdiffs method 2013-09-17 13:55:41 -07:00
parser Differential - make sure not to return change type header if we're not top level 2013-09-12 16:00:00 -07:00
phid Policy - introduce parentQuery and pass around policy configuration from parent to child 2013-09-11 12:19:34 -07:00
query Fix differential.getdiff, etc., for diffs with no Arcanist Project 2013-09-24 10:48:40 -07:00
remarkup Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
render Differential - make sure not to return change type header if we're not top level 2013-09-12 16:00:00 -07:00
search Remove legacy "touched" table and indexing 2013-09-12 13:04:09 -07:00
storage Fix differential.getdiff, etc., for diffs with no Arcanist Project 2013-09-24 10:48:40 -07:00
view ObjectHeader Status icons 2013-09-24 08:42:04 -07:00
DifferentialTasksAttacher.php Delete license headers from files 2012-11-05 11:16:51 -08:00