1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-04 19:08:27 +01:00
phorge-phorge/src/applications/differential
epriestley 62a402491a Allow encrypted mail to be more specific about which object is affected
Summary:
Depends on D19487. Ref T13151. See PHI647. For some objects, like revisions, we can build slightly more useful secure email without actually disclosing anything.

In the general case, the object monogram may disclose information (`#acquire-competitor`) but most do not, so applications can whitelist an acceptable nondisclosing subject and link.

Support doing this, and make Differential do it. When we don't have a whitelisted URI but do know the object the mail is about, include a generic PHID-based URI; these are always nondisclosing.

Test Plan:
  - Without the Differential changes, sent normal mail (no changes) and secure mail (new generic PHID-based link).
  - With the Differential changes, sent secure mail; got richer subject and body link.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13151

Differential Revision: https://secure.phabricator.com/D19488
2018-06-12 11:55:18 -07:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
application Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Define Differential email action in terms of EditEngine 2017-01-02 13:25:45 -08:00
conduit Remove "Large Changes" documentation and make some minor behavioral improvements 2018-04-05 06:40:46 -07:00
config Add yaml files to differential.whitespace-matters 2017-11-15 11:57:11 -08:00
constants Add some more UI reminder text about draft revisions 2018-03-08 12:07:40 -08:00
controller When showing a diff-of-diffs, hide files which didn't get any more changes and have no inlines 2018-05-16 17:18:53 -07:00
customfield Show an additional "Draft" tag on non-broadcasting revisions in a non-draft state 2018-04-03 11:09:49 -07:00
doorkeeper Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator 2017-08-09 11:04:52 -07:00
edge Provide revision parent/child edges in edge.search, and more information in differential.revision.search 2017-11-07 15:34:31 -08:00
editor Allow encrypted mail to be more specific about which object is affected 2018-06-12 11:55:18 -07:00
engine When showing a diff-of-diffs, hide files which didn't get any more changes and have no inlines 2018-05-16 17:18:53 -07:00
engineextension Add a "commits" attachment to "differential.diff.search" for retrieving local commit information 2018-04-19 17:25:06 -07:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
field Move misplaced validation for ambiguous fields in "Test Plan" to the right place 2017-06-30 06:36:05 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
harbormaster When publishing buildables in Differential, ignore autobuilds (local lint and unit) 2018-04-03 11:02:12 -07:00
herald Prepare to support an "Ignore generated files" flag in Owners 2018-05-05 08:46:47 -07:00
lipsum Mostly modularize the Differential "update" transaction 2018-03-06 09:10:32 -08:00
mail Rename "needReviewerStatus()" into "needReviewers()" 2017-03-20 16:46:16 -07:00
management When showing a diff-of-diffs, hide files which didn't get any more changes and have no inlines 2018-05-16 17:18:53 -07:00
parser Separate changeset analysis code from DifferentialDiff and provide a standalone rebuild-changesets workflow 2018-05-16 17:17:28 -07:00
phid Make all revision status readers explicitly read modern or legacy status 2017-08-11 17:22:22 -07:00
query Add a standalone view for browsing changesets of very large revisions 2018-04-05 06:35:06 -07:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Use more consistent diff coloration in unified diffs 2018-06-08 09:39:34 -07:00
search Reduce the amount of boilerplate that implementing FerretInterface requires 2017-09-07 13:23:31 -07:00
storage When showing a diff-of-diffs, hide files which didn't get any more changes and have no inlines 2018-05-16 17:18:53 -07:00
typeahead Fix spelling 2017-10-09 10:48:04 -07:00
view Improve color use in "[+++- ]" element for colorblind users 2018-04-19 17:24:44 -07:00
xaction Remove unusual unicode marks in Differential action dropdown 2018-04-27 11:00:56 -07:00
DifferentialGetWorkingCopy.php Extend from Phobject 2015-06-15 18:02:27 +10:00