epriestley 30ae22bfcf Fix many encoding and architecture problems in Diffusion request and URI handling ... Summary: Diffusion request/uri handling is currently a big, hastily ported mess. In particular, it has: - Tons and tons of duplicated code. - Bugs with handling unusual branch and file names. - An excessively large (and yet insufficiently expressive) API on DiffusionRequest, including a nonsensical concrete base class. - Other tools were doing hacky things like passing ":" branch names. This diff attempts to fix these issues. - Make the base class abstract (it was concrete ONLY for "/diffusion/"). - Move all URI generation to DiffusionRequest. Make the core static. Add unit tests. - Delete the 300 copies of URI generation code throughout Diffusion. - Move all URI parsing to DiffusionRequest. Make the core static. Add unit tests. - Add an appropriate static initializer for other callers. - Convert all code calling `newFromAphrontRequestDictionary` outside of Diffusion to the new `newFromDictionary` API. - Refactor static initializers to be sensibly-sized. - Refactor derived DiffusionRequest classes to remove duplicated code. - Properly encode branch names (fixes branches with "/", see <https://github.com/facebook/phabricator/issues/100>). - Properly encode path names (fixes issues in D1742). - Properly escape delimiter characters ";" and "$" in path names so files like "$100" are not interpreted as "line 100". - Fix a couple warnings. - Fix a couple lint issues. - Fix a bug where we would not parse filenames with spaces in them correctly in the Git browse query. - Fix a bug where Git change queries would fail unnecessarily. - Provide or improve some documentation. This thing is pretty gigantic but also kind of hard to split up. If it's unreasonably difficult to review, let me know and I can take a stab at it though. This supplants D1742. Test Plan: - Used home, repository, branch, browse, change, history, diff (ajax), lastmodified (ajax) views of Diffusion. - Used Owners typeaheads and search. - Used diffusion.getrecentcommitsbypath method. - Pushed a change to an absurdly-named file on an absurdly-named branch, everything worked properly. {F9185} Reviewers: nh, vrana, btrahan Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1921		2012-03-19 19:52:14 -07:00
..
applicationconfiguration	Respect query string when redirecting from missing trailing /	2012-03-07 13:47:20 -08:00
console	Add "final" to more classes	2012-03-13 11:18:11 -07:00
controller	Modularize oauth.	2011-02-27 20:38:11 -08:00
default/configuration	Fix many encoding and architecture problems in Diffusion request and URI handling	2012-03-19 19:52:14 -07:00
exception	Add "final" to more classes	2012-03-13 11:18:11 -07:00
mapper	Always match full path in URI Mapper	2012-03-01 15:27:03 -08:00
request	Add "final" to more classes	2012-03-13 11:18:11 -07:00
response	Add "final" to more classes	2012-03-13 11:18:11 -07:00
sink	Encode "<" and ">" in JSON/Ajax responses to prevent content-sniffing attacks	2012-02-14 14:51:51 -08:00
writeguard	Create AphrontWriteGuard, a backup mechanism for CSRF validation	2011-08-16 13:29:57 -07:00