1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/differential
bhiller 15e71e9bf4 [differential] Prevent un-closeable overlay
Summary:
Currently if I go to leave an inline comment and then decide
against it and hit <tab>-<enter>, the inline comment edit dialog closes
but the overlay doesn't disappear due to a JS error around trying to
access the markup property of null. This fixes that by setting the
payload to an array with empty markup so that the JS works and the
overlay disappears.

Test Plan:
clicked on the line number column, then pressed ok and
confirmed the dialog closed, the overlay disappeared and there were no
JS errors. also tested that for clicking the reply link and when editing
an existing inline comment.

Reviewed By: aran
Reviewers: epriestley, aran
CC: aran, bh
Revert Plan:
OK

Differential Revision: 154
2011-04-20 18:50:57 -07:00
..
constants Implemented "Plan Changes" action for differential. 2011-04-13 16:58:22 -07:00
controller [differential] Prevent un-closeable overlay 2011-04-20 18:50:57 -07:00
data Get rid of +x on a bunch of nonexecutable files because I failed to set 2011-04-02 16:47:20 -07:00
editor Create timeline events for comments 2011-04-14 22:18:01 -07:00
mail Don't send a blank "COMMITS" field for mark-committed revisions. 2011-04-10 14:36:04 -07:00
parser Fixed whitespace options in Differential. 2011-04-19 23:07:44 -07:00
storage Lint and unit star support. 2011-04-10 17:19:01 -07:00
view Fixed whitespace options in Differential. 2011-04-19 23:07:44 -07:00