1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-05 21:26:14 +01:00
phorge-phorge/src/applications/transactions/storage
epriestley 167f06d3eb Label transaction groups with a "group ID" so Herald can reconstruct them faithfully
Summary:
Ref T13283. See PHI1202. See D20519. When we apply a group of transactions, label all of them with the same "group ID".

This allows other things, notably Herald, to figure out which transactions applied together in a faithful way rather than by guessing, even though the guess was probably pretty good most of the time.

Also expose this to `transaction.search` in case callers want to do something similar. They get a list of transaction IDs from webhooks already anyway, but some callers use `transaction.search` outside of webhooks and this information may be useful.

Test Plan:
  - Ran Herald Test Console, saw faithful selection of recent transactions.
  - Changed hard limit from 1000 to 1, saw exception. Users should be very hard-pressed to hit this normally (they'd have to add 990-ish custom fields, then edit every field at once, I think) so I'm just fataling rather than processing some subset of the transaction set.
  - Called `transaction.search`, saw group ID information available.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13283

Differential Revision: https://secure.phabricator.com/D20524
2019-05-17 12:07:37 -07:00
..
PhabricatorApplicationTransaction.php Label transaction groups with a "group ID" so Herald can reconstruct them faithfully 2019-05-17 12:07:37 -07:00
PhabricatorApplicationTransactionComment.php Don't re-mention users for comment edits 2016-06-13 13:57:59 -07:00
PhabricatorEditEngineConfiguration.php Fix the incorrect link target for "Create Revision" as a Menu Item 2019-04-02 15:21:59 -07:00
PhabricatorEditEngineConfigurationTransaction.php Surface custom form instructions as a "Remarkup" field for the transaction layer 2019-04-10 11:13:03 -07:00
PhabricatorModularTransaction.php Fix an issue where transactions in mail were always rendered as text 2019-01-16 13:21:05 -08:00
PhabricatorModularTransactionType.php Allow modular transactions to override transaction title and body text in mail 2019-01-30 19:48:30 -08:00