1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/differential
epriestley 19bc91fd20 Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus
Summary:
Ref T2543. Converts the TYPE_STATUS transaction (used to render "This revision now requires changes to proceed.", "This revision is accepted and ready to land.", etc) to ModularTransactions.

Also, continue consolidating all the status-related information (here, more colors and icons) into a single place. By the end of this, we may learn that NEEDS_REVIEW uses //every// color.

Test Plan:
Reviewed old status transactions (unchanged) and created new ones (looked the same as the old ones).

(I plan to migrate all of these a few diffs from now, around when I change the storage format.)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18410
2017-08-11 17:20:40 -07:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
application Remove old "Landing Strategy" code 2017-06-23 08:13:53 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Define Differential email action in terms of EditEngine 2017-01-02 13:25:45 -08:00
conduit Completely remove "differential.find" Conduit API method 2017-08-11 13:38:28 -07:00
config Convert "enum" and "string" config options to new modular option types 2017-06-27 12:13:15 -07:00
constants Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus 2017-08-11 17:20:40 -07:00
controller Replace legacy Differential queries for "open" revisions with a modern mechanism 2017-08-11 13:37:11 -07:00
customfield Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator 2017-08-09 11:04:52 -07:00
doorkeeper Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator 2017-08-09 11:04:52 -07:00
edge Expose the commit/task/revision relationship edges to "edge.search" 2017-04-02 19:49:55 -07:00
editor Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus 2017-08-11 17:20:40 -07:00
engine Make yellow "draft" bubbles more generic 2017-01-13 09:02:19 -08:00
engineextension Provide a "Reviewers" attachment to "differential.revision.search" 2017-04-06 14:46:39 -07:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
field Move misplaced validation for ambiguous fields in "Test Plan" to the right place 2017-06-30 06:36:05 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
herald Fix a bad getStatus() call which is fataling during Herald rule evaluation 2017-03-22 10:03:38 -07:00
lipsum Rename "getReviewerStatus()" to "getReviewers()" 2017-03-20 17:11:40 -07:00
mail Rename "needReviewerStatus()" into "needReviewers()" 2017-03-20 16:46:16 -07:00
management Remove most of the legacy hunk code 2016-12-13 14:34:36 -08:00
parser Build a page for viewing all inline comments 2017-06-12 11:31:20 -07:00
phid Continue reducing callsites to ArcanistDifferentialRevisionStatus 2017-08-09 11:05:22 -07:00
query Remove legacy withStatus() method from RevisionQuery 2017-08-11 13:37:47 -07:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Correct the generation of "<th />" IDs on left-hand-side of image changesets 2017-05-17 06:26:45 -07:00
search Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator 2017-08-09 11:04:52 -07:00
storage Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus 2017-08-11 17:20:40 -07:00
typeahead Add a Differential revision status tokenizer datasource 2017-08-11 13:35:15 -07:00
view Remove a debugging "echo" that crept in in dccd799b 2017-08-11 05:50:43 -07:00
xaction Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus 2017-08-11 17:20:40 -07:00
DifferentialGetWorkingCopy.php Extend from Phobject 2015-06-15 18:02:27 +10:00