1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src
Wez Furlong 1b6eced757 avoid claiming that the source of a file move was unchanged
Summary:
sometimes we show moved files as unchanged, sometimes deleted,
and sometimes inconsistent with what actually happened at the
destination of the move.  Rather than make a false claim,
omit the 'not changed' notice if this is the source of a move.

Background: one of our users was confused by the source of a move
claiming to be unmodified when the destination of the move had
extensive modifications.

There may be a question about the quality of the data we keep/compute
about the changes, so maybe we could do a better or more consistent
job there (may just be nuances of the SCM in use); this approach
just smoothes that out and doesn't require fixing up the status
in pre-existing diffs.

Test Plan:
In the facebook phabricator, D594195#739ace1a and D590020#b97cfcfd
For others, find a diff that has moved files.
For the source of a move, we should now only show the "X moved to Y"
header and not the "unchanged" shield.

Reviewers: nh, vrana, epriestley

Reviewed By: vrana

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3669
2012-10-09 14:16:21 -07:00
..
aphront Make celerity be able to render full uris 2012-10-09 09:31:20 -07:00
applications avoid claiming that the source of a file move was unchanged 2012-10-09 14:16:21 -07:00
docs Update database.schema doc to include how to upgrade the schema 2012-10-04 15:26:16 -07:00
infrastructure Make celerity be able to render full uris 2012-10-09 09:31:20 -07:00
rsrc Use sprites for (nearly) all application icons 2012-08-14 14:23:55 -07:00
view Make image macro name selectable 2012-10-09 13:38:34 -07:00
__celerity_resource_map__.php Minor, fix some missing dependencies for installs with notifications off. 2012-10-09 08:34:06 -07:00
__phutil_library_init__.php Distinguish between aphront and phabricator. 2011-01-22 17:45:28 -08:00
__phutil_library_map__.php Hook Ponder to Subscriptions 2012-10-08 14:47:21 -07:00